1494263 - Rework the SVG filter code to obtain filter frames via SVGObserverUtils

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

Right now we have a function nsSVGFilterInstance::GetFilterFrame that gets the filter frame using its own single shot IDTracker. This whole setup is really poorly designed. We should only ever be getting SVG referenced frames via SVGObserverUtils to make sure that we set up observers correctly. The observers have already been set up under the SVGObserverUtils::HasValidFilter/HasNoOrValidFilter/HasInvalidFilter calls after all. We should get rid of nsSVGFilterInstance::GetFilterFrame, add a replacement to SVGObserverUtils, and rework the SVG filter code to use that (all the places that create an nsFilterInstance should be passing an nsTArray<nsSVGFilterFrame>& to its ctor). There's a decent chance that cleaning up this mess will fix some of the filter related refcounting bugs that we have.

Comment 1

[Jonathan Watt [:jwatt]]

I'm adding the necessary function to SVGObserverUtils in a separate bug for a refactoring of the SVGObserverUtils filter code.

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1494263 part 1 - pass filterFrames around rather than getting them again and again r=emilio

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 1494263 part 2 - try marking some tests as passing now r=emilio

Depends on D189704

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=308d73b6d8dcc7b9d67dbe4513564ede29019c32 (none of the orange seems related to this).

https://treeherder.mozilla.org/jobs?repo=try&revision=3a3b0e1be0a2a1c39b8e7847283140d1abb1d75a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de2e58be4e20
part 1 - pass filterFrames around rather than getting them again and again r=emilio
https://hg.mozilla.org/integration/autoland/rev/4b3dda4d2972
part 2 - try marking some tests as passing now r=emilio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/de2e58be4e20
https://hg.mozilla.org/mozilla-central/rev/4b3dda4d2972