1868479 - Since FF 120, backdrop-filter no longer works with svg filters

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[PCigales]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

Style a div element containing images with "backdrop-filter:url(#filter)" where #filter is a filter inside a SVG in the same document:
<svg id="svgfilter" xmlns="http://www.w3.org/2000/svg" width="0" height="0" style="position:absolute;top:0px;left:0px;">
<filter id="filter">
<feComponentTransfer color-interpolation-filters="sRGB">
<feFuncR type="gamma" offset="0.5" amplitude="0.5" exponent="1"/>
<feFuncG type="gamma" offset="0.5" amplitude="0.5" exponent="1"/>
<feFuncB type="gamma" offset="0.5" amplitude="0.5" exponent="1"/>
</feComponentTransfer>
</filter>
</svg>

Actual results:

Nothing happens, the images are displayed as they are.

Expected results:

Images should be lighter, as they were in previous versions of Firefox, up to 119.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Timothy Nikkel (:tnikkel)]

Can you please provide a full testcase?

I attempted to create one based on your instructions but I was not able to observe any difference in rendering between Firefox vs Safari in any of the things I tried.

Alternatively, you could run https://mozilla.github.io/mozregression/ which would narrow down to the exact change that caused the difference

Comment 3

[PCigales]

Attachment: test.htm

Comment 4

[PCigales]

Thank you very much for your answer.
I prepared a testcase as you requested. The filter works on Chrome/Edge and on Firefox 119, but is not applied in Firefox 120.
I am going to use https://mozilla.github.io/mozregression/ to see if I can find what caused the issue.

Comment 5

[PCigales]

I used the tool on mozilla-beta rep and here is the result:

• last good: f2a69b23
• first bad: 97e8b9bb

app_name: firefox
build_date: 2023-10-16 20:28:24.169000
build_file: C:\Users\Cyril.mozilla\mozregression\persist\97e8b9bbb11e-shippable--mozilla-beta--target.zip
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EBnTLvoMThWR2WYBQtp7mQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 97e8b9bbb11e77faf6188c7a1dde9ca93c5ed34c
pushlog_url: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=11d1909ae147645f934856a3d3236ee83fd99444&tochange=97e8b9bbb11e77faf6188c7a1dde9ca93c5ed34c
repo_name: mozilla-beta
repo_url: https://hg.mozilla.org/releases/mozilla-beta
task_id: EBnTLvoMThWR2WYBQtp7mQ

Comment 6

[Mayank Bansal]

2023-12-06T14:38:44.843000: DEBUG : Found commit message:
Bug 1494263 part 2 - try marking some tests as passing now r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D189705

Comment 7

[PCigales]

I have run again the tool without mentioning any repository and I think I have narrowed the commit liable for the issue:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7cc8baac415ebcf55e5bfe27795610c8f53bbbad&tochange=4b3dda4d2972331b75c2f18e2cda51b39c1c89a4

It is related to this bug, related to the svg filter code, so it makes sense: https://bugzilla.mozilla.org/show_bug.cgi?id=1494263

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1494263

Comment 9

[Robert Longson [:longsonr]]

Attachment: Bug 1868479 - Fix backdrop-filter with SVG filters r=emilio

Comment 10

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e7a0d17a2a8f5f5052a7b49f4e0f4d7fd5ef6665

Comment 11

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=2ce3d026f68829e4b4799249557b27da80f05d0a

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f94f2c15a352
Fix backdrop-filter with SVG filters r=dholbert

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43561 for changes under testing/web-platform/tests

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f94f2c15a352

Comment 15

[Robert Longson [:longsonr]]

Comment on attachment 9367299 [details]
Bug 1868479 - Fix backdrop-filter with SVG filters r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: backdrop-filter that's defined using a url doesn't work any more.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch is limited to determining whether we're dealing with a backdrop-filter or a filter and we have lots of pre-existing filter tests.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367299 [details]
Bug 1868479 - Fix backdrop-filter with SVG filters r=emilio

Approved for 121.0rc1.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/941a6a229733