1494311 - Make mtransport API more IPC friendly

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Byron Campen [:bwc]]

Once we have the mtransport API all in one place, and properly encapsulated, we should write webidl types for the parameters on this API. This will make the API a little cleaner, but more importantly, is a step toward exposing this API over IPC.

Comment 1

[Byron Campen [:bwc]]

So webidl types are not inherently IPC-able, on further inspection. Still, there is some work we can do to make the mtransport API easier to surface via IPC.

* Use nsCString instead of std::string
* Use nsTArray instead of std::vector
* Use int instead of size_t?

Comment 2

[Byron Campen [:bwc]]

After fiddling with this a bit, RTCConfiguration does not look IPC-able, because RTCCertificate is not either. Probably should modify Init to take just the parts of RTCConfiguration it needs (which are IPC-able).

Comment 3

[Byron Campen [:bwc]]

Also, ditching CandidateInfo in favor of longer param lists will avoid some work.

Comment 4

[Byron Campen [:bwc]]

It seems that we have IPC support for std::string after all, but nobody has ever used it. No support for std::vector, however.

Comment 5

[Byron Campen [:bwc]]

As part of this, I'm also going to establish a base-class for both the STS-based and IPC-based implementations.

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1494311: (WIP) Making the mtransport API a little more IPC friendly.

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3345daeb578c6b2254e3139611b351ff252f53d

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85a17077a260dd98179b695a2409f6c5cd6846d7

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=052b0f4c50660a1f508fd334ca3fc5907c3c1ac5

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11474e9797a25f6a434e25451e9e421d6662b569

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99631dfaa4cb8a488b0f7773fcbc171639a79720

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8c00788402b55b59ac34cbe66cbf09cd3b11622

Comment 13

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1598ca979e6e97d19400bc2a94398023fb154a6e

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4062e2bde013bbcdad00d523f01af1fa64af2aa

Comment 15

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58e95271aaa2220eb5468565c9ef8005b74068ce

Comment 16

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e09e83ea698e22d7d5f49ce52d16387f596be1a

Comment 17

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87ed1b72e40fb8d17673f090e4fb929cd66b3f69

Comment 18

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2343f87875c6719d1abe51cda23329e7bb796727

Comment 19

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=18aa790a3d64e45cac141f6a2b5659b819a9eb1d

Comment 20

[Byron Campen [:bwc]]

Attachment: Bug 1494311: Making the mtransport API a little more IPC friendly, and establishing a proper base-class.

Comment 21

[Byron Campen [:bwc]]

mt, while looking over the key serialization/deserialization stuff we talked about, let me know if you would prefer me to apply the various clang-format/clang-tidy fixes suggested by reviewbot; since we might be moving those functions to NSS, we might not want to mess with the formatting.

Comment 22

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc896623dfb8ec9b33f8fef4c9f240c2437cf385

Comment 23

[Martin Thomson [:mt:]]

The requests that reviewbot makes are pretty easy to revert. I'd make it happy by preference. NSS runs a different formatter, so any changes will look different if the code moves.

Comment 24

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bbecc639513c122a657ea91362c2ae1a5a7b54b

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ab42c7de77d
Making the mtransport API a little more IPC friendly, and establishing a proper base-class. r=mt,mjf

Comment 26

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7ab42c7de77d