1494381 - (wr-video-color) [meta] [project] Proper colorspace support and color rendering for video playback

Status: NEW

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

This is a meta bug to track improving our handle of different colorspaces, having accurate colour rendering, including proper handling of PC [0-255] vs studio range [16-240].

Right now we only support BT.601 and BT.709, and it's not complete across all compositor or if video decoding hardware acceleration is used

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Is this the right component? Most dependent bugs are Core Graphics.

Comment 2

[Jean-Yves Avenard [:jya]]

I hesitated to lodge it in gfx. The core work will be in gfx, but there are still things we need to do to get it working in all the decoders and media data structure.

I see that gfx has a colour component, so let's use that.

Comment 3

[kwpk.it]

I'm wondering whether a color rendering issue I am seeing is related to this; I am responsible for composing our organization's monthly newsletter - I use Google Slides to do so; the front page includes a color graphic, and columns outlined with a colored border.

The background of the color graphic is hex 990000 (verified via Serif Affinity Photo); the border for the text columns is also set to hex 990000. (verified via Google Slides text element border selection in Web browser).

When I look at the page in Google Chrome, both the graphic background and text column borders are pretty much the same; when I look at the same page in Firefox 70, the text column borders appear much brighter than the color graphic's background. Some experimentation in Firefox 70 suggests that in order to make the two colors appear similar, I would need to set the text border color to something close to hex 880000.

I have recently switched to using a ThinkPad P1 Gen 2 with the 4K non-touch screen (15.6" UHD (3840 x 2160) IPS 500 nits, anti-glare with Dolby Vision™ HDR 400); I noticed the color rendering issue for the first time on this display. This display is rated at 100% Adobe Color gamut - the machine I used previously did not have as good a display. I noticed the different color rendering only on the new ThinkPad P1 G2 display.

I'd be happy to supply screen shots, or access to a test version of the newsletter, on Google Slides, if doing so would help.

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to kwpk.it from comment #3)

I'm wondering whether a color rendering issue I am seeing is related to this; I am responsible for composing our organization's monthly newsletter - I use Google Slides to do so; the front page includes a color graphic, and columns outlined with a colored border.

Unlikely, this bug is about tracking HDR support for video elements Not images or document colours, in which case we only handle RGB 8 bits.

Comment 5

[Chris Peterson [:cpeterson]]

Unassigning bugs assigned to Bryce because he no longer works at Mozilla.