1494474 - ANGLE doesn't support asynchronous concurrent glProgramBinary

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P1)

Description

[Kelsey Gilbert [:jgilbert]]

KHR_parallel_shader_compile[1] integration should have laid the groundwork for this, but :mattwoodrow is seeing glProgramBinary as not hooked up, and is calling CreateShader synchronously.

[1]: https://www.khronos.org/registry/OpenGL/extensions/KHR/KHR_parallel_shader_compile.txt

I'll file an ANGLE issue.

Comment 1

[Kelsey Gilbert [:jgilbert]]

https://bugs.chromium.org/p/angleproject/issues/detail?id=2857

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1494474 - Make ProgramImpl::load() return a task and support asynchronously waiting for it to complete. r?jgilbert

MozReview-Commit-ID: Cov0FWci0t7

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1494474 - Move task definitions to earlier in the file. r?jgilbert

MozReview-Commit-ID: 8fuMD6plkxq

Depends on D7549

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1494474 - Support async Program::load for ProgramD3D. r?jgilbert

MozReview-Commit-ID: GPvyK71GGPX

Depends on D7550

Comment 5

[Kelsey Gilbert [:jgilbert]]

Please rebase this changeset on top of chromium/master so we can upstream it.
I've taken a couple stabs at this and haven't had luck.

Upstreaming this blocks updating ANGLE.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Fixed upstream:
https://bugs.chromium.org/p/angleproject/issues/detail?id=2857#c9