1520948 - (angle-68) Update ANGLE in Firefox 68

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1520948 - Update ANGLE to chromium/3729..moz/firefox-68.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1520948 - Updates to update-angle.py.

• Support DEFFILE in update-angle.py.
• Add standalone --check

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1520948 - Update test failures.

Depends on D23772

Comment 4

[Kelsey Gilbert [:jgilbert]]

Linking error on MinGW:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=240015576&revision=ccb7d15fa4315748458db1b5d2d5efef6ed1c685

Please advise!
It seems to link fine on all other configurations. Why is only MinGW complaining about duplicate symbols here?

Comment 5

[Jacek Caban]

As far as I can see, they are ideed duplicated, but one of places where it's defined is a .def file used for libGLESv2.dll. The importlib is linked as if it was a static lib to be included inside linked library, it's just referenced as |../libGLESv2/liblibGLESv2.a|. I guess that using -l (eg. -L../libSLESv2 -l libGLESv2) could help. AFAICS, moz.build file uses USE_LIBS for it, I lost track of how those work in moz.builds.

Comment 6

[Kelsey Gilbert [:jgilbert]]

I'm gonna try building with -DANGLE_USE_EGL_LOADER. I don't see how the code is supposed to /not/ have duplicate symbols without it, even though we didn't use to need it.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Try looking greenish.

I'll attempt to land this on Monday.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c39da3c62234
Updates to update-angle.py. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/167ee7c46b84
Update ANGLE to chromium/3729..moz/firefox-68.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a69337c09a3a
Update test failures.

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c39da3c62234
https://hg.mozilla.org/mozilla-central/rev/167ee7c46b84
https://hg.mozilla.org/mozilla-central/rev/a69337c09a3a

Comment 10

[Jorg K (CEST = GMT+2)]

Hmm, since this landed, I can't compile Thunderbird any more :-(

0:15.70 c:/mozilla-source/comm-central/gfx/angle/checkout/src\libANGLE/renderer/d3d/d3d11/converged/CompositorNativeWindow11.h(15,10): fatal error: 'dispatcherqueue.h' file not found

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/converged/CompositorNativeWindow11.h#15

and

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp#67

EDIT: Commenting out
https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/gfx/angle/checkout/src/common/platform.h#49

does not help, neither does changing this to #undef ANGLE_ENABLE_WINDOWS_STORE.

TB builds are working fine in automation and a colleague can also compile without problem. So I must be doing something wrong.

Jeff, any hints?

Comment 11

[Jorg K (CEST = GMT+2)]

Oh, I see, bug 1546491.

Comment 12

[Kelsey Gilbert [:jgilbert]]

Yep, you got it! You'll need at least the Windows 10 SDK 10.0.17134.0.

Comment 13

[Ionuț Goldan [:igoldan]]

Small perf win noticed:

== Change summary for alert #20874 (as of Thu, 09 May 2019 03:44:06 GMT) ==

Improvements:

2% tart windows10-64-shippable-qr opt e10s stylo 2.46 -> 2.41

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20874