Closed Bug 1494498 Opened 2 years ago Closed 2 years ago

Fix constraints logging.

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(1 file, 1 obsolete file)

We ran across this in bug 1468205 comment 16: our constraints logging is quite incomplete, as can be seen here [1].

We should improve this logging, as it can sometimes be hard to tell what constraints a site is passing in.

[1] https://searchfox.org/mozilla-central/rev/ce57be88b8aa2ad03ace1b9684cd6c361be5109f/dom/media/webrtc/MediaEngineRemoteVideoSource.cpp#800-827
See Also: → 1494806
Attachment #9012751 - Attachment is obsolete: true
Comment on attachment 9012773 [details]
Bug 1494498 - Some constraints were missing in MediaManager logs. r?pehrsons

Andreas Pehrson [:pehrsons] has approved the revision.
Attachment #9012773 - Flags: review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0a586d4d64a
Some constraints were missing in MediaManager logs. r=pehrsons
Depends on: 1495478
https://hg.mozilla.org/mozilla-central/rev/d0a586d4d64a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08125cd5d357
Backed out changeset d0a586d4d64a for Windows MinGW bustages on MediaTrackConstraints.cpp
You need to log in before you can comment on or make changes to this bug.