Closed Bug 1494513 Opened 11 months ago Closed 2 months ago

Permafailing Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] | After Assertion failure: mEventTarget / currentThread->EventQueue() (Shutdown() may only be called from an XPCOM thread)

Categories

(Core :: WebVR, defect, P2, critical)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kip)

References

Details

(Keywords: crash, intermittent-failure, Whiteboard: [stockwell fixed:other])

Crash Data

Attachments

(2 files)

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=201809766&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/WMOc1Ii4TUaBmUH8JaZcXQ/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/WMOc1Ii4TUaBmUH8JaZcXQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

17:13:38     INFO - --DOMWINDOW == 5 (0x120b12c00) [pid = 2462] [serial = 5] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1538004928/build/tests/reftest/tests/dom/vr/test/reftest/wrapper.html?draw_rect.png]
17:13:38     INFO - --DOMWINDOW == 4 (0x11ead9400) [pid = 2462] [serial = 6] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
17:13:38     INFO - --DOMWINDOW == 3 (0x120b17400) [pid = 2462] [serial = 9] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
17:13:38     INFO - --DOMWINDOW == 2 (0x120b17800) [pid = 2462] [serial = 8] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1538004928/build/tests/reftest/tests/dom/vr/test/reftest/wrapper.html?change_size.png]
17:13:38     INFO - --DOMWINDOW == 1 (0x11eadf400) [pid = 2462] [serial = 4] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1538004928/build/tests/reftest/tests/dom/vr/test/reftest/draw_rect.html]
17:13:38     INFO - --DOMWINDOW == 0 (0x120b12000) [pid = 2462] [serial = 7] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1538004928/build/tests/reftest/tests/dom/vr/test/reftest/change_size.html]
17:13:38     INFO - nsStringStats
17:13:38     INFO -  => mAllocCount:          10944
17:13:38     INFO -  => mReallocCount:            0
17:13:38     INFO -  => mFreeCount:           10944
17:13:38     INFO -  => mShareCount:           8382
17:13:38     INFO -  => mAdoptCount:            625
17:13:38     INFO -  => mAdoptFreeCount:        641
17:13:38     INFO -  => Process ID: 2462, Thread ID: 140735227400960
17:13:38     INFO - 1538007218637	Marionette	DEBUG	Received observer notification xpcom-will-shutdown
17:13:38     INFO - 1538007218638	Marionette	INFO	Stopped listening on port 2828
17:13:38     INFO - 1538007218638	Marionette	DEBUG	Remote service is inactive
17:13:38     INFO - [Parent 2459, Main Thread] WARNING: NS_ENSURE_TRUE(mDB) failed: file /builds/worker/workspace/build/src/netwerk/cache/nsDiskCacheDeviceSQL.cpp, line 1422
17:13:38     INFO - [Parent 2459, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/workspace/build/src/gfx/layers/apz/src/APZUpdater.cpp, line 416
17:13:38     INFO - [Parent 2459, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 763
17:13:38     INFO - Assertion failure: mEvents, at /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1097
17:13:38     INFO - Assertion failure: mEventTarget, at /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:763
17:13:38     INFO - #01: nsIEventTarget::Dispatch(nsIRunnable*, unsigned int) [mfbt/AlreadyAddRefed.h:126]
17:13:38     INFO - 
17:13:38     INFO - #02: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:544]
17:13:38     INFO - 
17:13:40     INFO - #03: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:204]
17:13:40     INFO - 
17:13:40     INFO - #04: libsystem_pthread.dylib + 0x405a
17:13:40     INFO - 
17:13:40     INFO - #05: libsystem_pthread.dylib + 0x3fd7
17:13:40     INFO - 
17:13:40     INFO - #01: nsThread::Shutdown() [xpcom/threads/nsThreadUtils.cpp:519]
17:13:40     INFO - 
17:13:40     INFO - #02: mozilla::gfx::VRThread::Shutdown() [xpcom/base/nsCOMPtr.h:396]
17:13:40     INFO - 
17:13:40     INFO - #03: mozilla::gfx::VRDisplayHost::~VRDisplayHost() [mfbt/RefPtr.h:69]
17:13:40     INFO - 
17:13:40     INFO - #04: mozilla::gfx::impl::VRDisplayPuppet::~VRDisplayPuppet() [memory/mozalloc/mozalloc.h:163]
17:13:40     INFO - 
17:13:40     INFO - #05: mozilla::gfx::VRSystemManagerPuppet::Shutdown() [xpcom/ds/nsTArray.h:2338]
17:13:40     INFO - 
17:13:40     INFO - #06: mozilla::gfx::VRManager::Destroy() [gfx/vr/VRManager.cpp:174]
17:13:40     INFO - 
17:13:40     INFO - #07: mozilla::gfx::VRManagerParent::UnregisterFromManager() [mfbt/RefPtr.h:69]
17:13:40     INFO - 
17:13:40     INFO - #08: mozilla::gfx::VRManagerParent::ActorDestroy(mozilla::ipc::IProtocol::ActorDestroyReason) [gfx/vr/ipc/VRManagerParent.cpp:156]
17:13:40     INFO - 
17:13:40     INFO - #09: mozilla::gfx::PVRManagerParent::DestroySubtree(mozilla::ipc::IProtocol::ActorDestroyReason) [s3:gecko-generated-sources:f6a077b9144eba1234b2daf743c587815af1910993af1e878b698fe420e04665de0e8248eec78a6bc39aa29d70515fefaf94c70bb2e30ad53524225eb41dbb60/ipc/ipdl/PVRManagerParent.cpp::1104]
17:13:40     INFO - 
17:13:40     INFO - #10: mozilla::gfx::PVRManagerParent::OnChannelClose() [s3:gecko-generated-sources:f6a077b9144eba1234b2daf743c587815af1910993af1e878b698fe420e04665de0e8248eec78a6bc39aa29d70515fefaf94c70bb2e30ad53524225eb41dbb60/ipc/ipdl/PVRManagerParent.cpp::1069]
17:13:40     INFO - 
17:13:40     INFO - #11: mozilla::detail::RunnableMethodImpl<mozilla::ipc::MessageChannel*, void (mozilla::ipc::MessageChannel::*)(), false, (mozilla::RunnableKind)1>::Run() [xpcom/threads/nsThreadUtils.h:1178]
17:13:40     INFO - 
17:13:40     INFO - #12: MessageLoop::RunTask(already_AddRefed<nsIRunnable>) [xpcom/base/nsCOMPtr.h:396]
17:13:40     INFO - 
17:13:40     INFO - #13: MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask&&) [ipc/chromium/src/base/message_loop.cc:459]
17:13:40     INFO - 
17:13:40     INFO - #14: MessageLoop::DoWork() [ipc/chromium/src/base/message_loop.cc:534]
17:13:40     INFO - 
17:13:40     INFO - #15: base::MessagePumpDefault::Run(base::MessagePump::Delegate*) [ipc/chromium/src/base/message_pump_default.cc:38]
17:13:40     INFO - 
17:13:40     INFO - #16: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:598]
17:13:40     INFO - 
17:13:40     INFO - #17: base::Thread::ThreadMain() [ipc/chromium/src/base/thread.cc:201]
17:13:40     INFO - 
17:13:40     INFO - #18: ThreadFunc(void*) [ipc/chromium/src/base/platform_thread_posix.cc:41]
17:13:40     INFO - 
17:13:40     INFO - #19: libsystem_pthread.dylib + 0x405a
17:13:40     INFO - 
17:13:40     INFO - #20: libsystem_pthread.dylib + 0x3fd7
17:13:40     INFO - 
17:13:40    ERROR - TEST-UNEXPECTED-FAIL | Last test finished | application terminated with exit code 1
17:13:40     INFO - REFTEST INFO | Copy/paste: /Users/cltbld/tasks/task_1538004928/build/macosx64-minidump_stackwalk /var/folders/7l/_bnx0ccn5h38z8ffmd98rk0r00000w/T/tmpmeSXEK.mozrunner/minidumps/ECD34B4F-A95F-4046-8E61-53F2829D88C5.dmp /Users/cltbld/tasks/task_1538004928/build/symbols
17:13:57     INFO - REFTEST INFO | Saved minidump as /Users/cltbld/tasks/task_1538004928/build/blobber_upload_dir/ECD34B4F-A95F-4046-8E61-53F2829D88C5.dmp
17:13:57     INFO - REFTEST INFO | Saved app info as /Users/cltbld/tasks/task_1538004928/build/blobber_upload_dir/ECD34B4F-A95F-4046-8E61-53F2829D88C5.extra
17:13:57     INFO - REFTEST PROCESS-CRASH | Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)]
17:13:57     INFO - Crash dump filename: /var/folders/7l/_bnx0ccn5h38z8ffmd98rk0r00000w/T/tmpmeSXEK.mozrunner/minidumps/ECD34B4F-A95F-4046-8E61-53F2829D88C5.dmp
17:13:57     INFO - Operating system: Mac OS X
17:13:57     INFO -                   10.10.5 14F27
17:13:57     INFO - CPU: amd64
17:13:57     INFO -      family 6 model 69 stepping 1
17:13:57     INFO -      4 CPUs
17:13:57     INFO - 
17:13:57     INFO - GPU: UNKNOWN
17:13:57     INFO - 
17:13:57     INFO - Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
17:13:57     INFO - Crash address: 0x0
17:13:57     INFO - Process uptime: 10 seconds
17:13:57     INFO - 
17:13:57     INFO - Thread 40 (crashed)
17:13:57     INFO -  0  XUL!nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int) [nsThread.cpp:5177bb8cb2cebb01b3dc26233a59a192ed9a29bc : 763 + 0x0]
17:13:57     INFO -     rax = 0x0000000000000000   rdx = 0x00007fff79a581f8
17:13:57     INFO -     rcx = 0x0000000000000000   rbx = 0x0000000118a4aea0
17:13:57     INFO -     rsi = 0x00006c0000006c00   rdi = 0x00006b0000006c03
17:13:57     INFO -     rbp = 0x0000000134ac3e30   rsp = 0x0000000134ac3e10
17:13:57     INFO -      r8 = 0x0000000134ac3dc0    r9 = 0x0000000134ac4000
17:13:57     INFO -     r10 = 0x00007fff935683ef   r11 = 0x00007fff935683c0
17:13:57     INFO -     r12 = 0x000000010ffbe400   r13 = 0x0000000103af0f90
17:13:57     INFO -     r14 = 0x0000000000000000   r15 = 0x0000000134ac3e50
17:13:57     INFO -     rip = 0x0000000103af1032
17:13:57     INFO -     Found by: given as instruction pointer in context
Component: XPCOM → WebVR
It looks like VRThread::Shutdown is calling nsThread::Shutdown from a thread without an XPCOM event loop. That's a problem, because the nsThread shutdown sequence relies on dispatching an event to the calling thread's event queue when it's finished, and for non-XPCOM threads, that event will never be processed.
This doesn't fix the problem, but at least moves the resulting assertion
closer to the problematic caller, and makes it easier to diagnose.
Summary: Intermittent Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] | After Assertion failure: mEventTarget → Permafailing Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] | After Assertion failure: mEventTarget
It looks like VRThread::Shutdown is calling nsThread::Shutdown from a thread without an XPCOM event loop. That's a problem, because the nsThread shutdown sequence relies on dispatching an event to the calling thread's event queue when it's finished, and for non-XPCOM threads, that event will never be processed.
Keywords: leave-open
Crash Signature: [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] → [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)
Comment on attachment 9012712 [details]
Bug 1494513: Work around VRThread shutdown bug causing frequent intermittent failures. r=erahm

Eric Rahm [:erahm] has approved the revision.
Attachment #9012712 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4517cdd2d9d27edb875ad87a0aa5df0ead404dc
Bug 1494513: Work around VRThread shutdown bug causing frequent intermittent failures. r=erahm
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b3657ab8de7b
Work around VRThread shutdown bug causing frequent intermittent failures. r=erahm
Crash Signature: [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *) → [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)]
Crash Signature: [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)] → [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)] [@ nsThread::ShutdownInternal(bool)]
The assertion changed after kmag did an update to the bug, so it would be easier to fix at a later time.

Assertion failure: currentThread->EventQueue() (Shutdown() may only be called from an XPCOM thread), at /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp
Summary: Permafailing Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] | After Assertion failure: mEventTarget → Permafailing Last test finished | application crashed [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] | After Assertion failure: mEventTarget / currentThread->EventQueue() (Shutdown() may only be called from an XPCOM thread)
The crash here: 
https://crash-stats.mozilla.com/report/index/d8d68e20-73c6-4e98-a7e9-428620180928

hit the added assertion:
MOZ_RELEASE_ASSERT(currentThread->EventQueue()) (Shutdown() may only be called from an XPCOM thread)
Crash Signature: [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)] [@ nsThread::ShutdownInternal(bool)] → [@ nsThread::Dispatch(already_AddRefed<nsIRunnable>, unsigned int)] [@ nsThread::ProcessNextEvent(bool,bool *)] [@ nsThread::ShutdownInternal(bool)] [@ nsThread::ShutdownInternal | nsThread::Shutdown | mozilla::layers::ProfilerScreenshots::~ProfilerScr…
Latest occurrence from today https://treeherder.mozilla.org/logviewer.html#?job_id=202150176&repo=autoland&lineNumber=13132 

06:54:08     INFO - ++DOCSHELL 0D639800 == 9 [pid = 2556] [id = {4f18041a-1a1b-453a-ab02-e73d92d75c97}]
06:54:08     INFO - ++DOMWINDOW == 22 (0B05B8E0) [pid = 2556] [serial = 22] [outer = 00000000]
06:54:08     INFO - ++DOMWINDOW == 23 (13B26C00) [pid = 2556] [serial = 23] [outer = 0B05B8E0]
06:54:08     INFO - 1538117648616	Marionette	TRACE	1 <- [1,2,null,{"value":"reftest@mozilla.org"}]
06:54:08     INFO - ++DOCSHELL 16E07C00 == 10 [pid = 2556] [id = {e75dcd6f-e39c-42a5-b46e-daff9ef55b47}]
06:54:08     INFO - ++DOMWINDOW == 24 (0B05BB40) [pid = 2556] [serial = 24] [outer = 00000000]
06:54:08     INFO - ++DOMWINDOW == 25 (16E08400) [pid = 2556] [serial = 25] [outer = 0B05BB40]
06:54:08     INFO - [Parent 2556, Main Thread] WARNING: Could not get window class style: file z:/build/build/src/widget/windows/nsWindow.cpp, line 7383
06:54:08     INFO - 1538117648748	Marionette	TRACE	1 -> [0,3,"WebDriver:DeleteSession",{}]
06:54:08     INFO - 1538117648751	Marionette	TRACE	1 <- [1,3,null,{"value":null}]
06:54:08     INFO - 1538117648760	Marionette	DEBUG	Closed connection 1
06:54:08     INFO - [Parent 2556, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [Child 4816, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [Child 4816, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [GPU 5672, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [GPU 567
06:54:08     INFO - ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
06:54:08     INFO - 2, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [GPU 5672, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_ch[Child 4816,annel_win.cc, line 3 Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file z:/build/build/src/xpcom/threads/nsThread.cpp, line 929
06:54:08     INFO - 46
06:54:08     INFO - [Parent 2556, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
06:54:08     INFO - [Parent 2556, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file z:/build/build/src/layout/base/nsDocumentViewer.cpp, line 3539
06:54:08     INFO - [Parent 2556, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004001: file z:/build/build/src/dom/xul/nsXULPrototypeCache.cpp, line 335
06:54:08     INFO - [Parent 2556, Main Thread] WARNING: Could not get window class style: file z:/build/build/src/widget/windows/nsWindow.cpp, line 7383
06:54:08     INFO - ++DOCSHELL 1049E800 == 2 [pid = 2660] [id = {56261d56-b84a-4878-a0ef-3bbbe751c175}]
06:54:08     INFO - ++DOMWINDOW == 4 (011C08D0) [pid = 2660] [serial = 4] [outer = 00000000]
06:54:08     INFO - ++DOMWINDOW == 5 (104A0800) [pid = 2660] [serial = 5] [outer = 011C08D0]
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!gThread', file z:/build/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
06:54:08     INFO - ++DOMWINDOW == 6 (104A1400) [pid = 2660] [serial = 6] [outer = 011C08D0]
06:54:08     INFO - Assertion failure: mEvents, at z:/build/build/src/xpcom/threads/nsThread.cpp:1097
06:54:08     INFO - --DOMWINDOW == 2 (079EA000) [pid = 4816] [serial = 3] [outer = 00000000] [url = about:blank]
06:54:08     INFO - --DOCSHELL 0076A000 == 0 [pid = 4816] [id = {b81af788-3cf0-49b9-8cb5-38283dc271c2}]
06:54:08     INFO - --DOMWINDOW == 1 (007C5410) [pid = 4816] [serial = 1] [outer = 00000000] [url = about:blank]
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - [Child 4816, Main Thread] WARNING: '!mMainThread', file z:/build/build/src/xpcom/threads/nsThreadManager.cpp, line 510
06:54:08     INFO - --DOMWINDOW == 0 (0076B400) [pid = 4816] [serial = 2] [outer = 00000000] [url = about:blank]
06:54:08     INFO - nsStringStats
06:54:08     INFO -  => mAllocCount:           7783
06:54:08     INFO -  => mReallocCount:            0
06:54:08     INFO -  => mFreeCount:            7783
06:54:08     INFO -  => mShareCount:           4814
06:54:08     INFO -  => mAdoptCount:            471
06:54:08     INFO -  => mAdoptFreeCount:        471
06:54:08     INFO -  => Process ID: 4816, Thread ID: 3400
06:54:08     INFO - REFTEST TEST-START | file:///Z:/task_1538116560/build/tests/reftest/tests/layout/reftests/css-ui-invalid/input/input-valid.html == file:///Z:/task_1538116560/build/tests/reftest/tests/layout/reftests/css-ui-invalid/input/input-ref.html
06:54:08     INFO - REFTEST TEST-LOAD | file:///Z:/task_1538116560/build/tests/reftest/tests/layout/reftests/css-ui-invalid/input/input-valid.html | 0 / 41 (0%)
06:54:33     INFO - #01: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:519]
06:54:33     INFO - 
06:54:33     INFO - #02: nsComponentManagerImpl::GetServiceByContractID(char const *,nsID const &,void * *) [xpcom/components/nsComponentManager.cpp:1496]
06:54:33     INFO - 
06:54:33     INFO - #03: nsGetServiceByContractID::operator()(nsID const &,void * *) [xpcom/components/nsComponentManagerUtils.cpp:281]
06:54:33     INFO - 
06:54:33     INFO - #04: static void WatchdogMain(void *) [js/xpconnect/src/XPCJSContext.cpp:530]
06:54:33     INFO - 
06:54:33     INFO - #05: _PR_NativeRunThread [nsprpub/pr/src/threads/combined/pruthr.c:397]
06:54:33     INFO - 
06:54:33     INFO - #06: static unsigned int pr_root(void *) [nsprpub/pr/src/md/windows/w95thred.c:137]
06:54:33     INFO - 
06:54:33     INFO - #07: ucrtbase.DLL + 0x3e16f
06:54:33     INFO - 
06:54:33     INFO - #08: kernel32.dll + 0x53c45
06:54:33     INFO - 
06:54:33     INFO - #09: static void patched_BaseThreadInitThunk(int, void *, void *) [mozglue/build/WindowsDllBlocklist.cpp:701]
06:54:33     INFO - 
06:54:33     INFO - #10: ntdll.dll + 0x637f5
06:54:33     INFO - 
06:54:33     INFO - #11: ntdll.dll + 0x637c8
06:54:33     INFO - 
06:54:33     INFO - A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down


06:54:45     INFO - REFTEST PROCESS-CRASH | file:///Z:/task_1538116560/build/tests/reftest/tests/layout/reftests/css-ui-invalid/input/input-valid.html | application crashed [@ nsThread::ProcessNextEvent(bool,bool *)]
06:54:45     INFO - Crash dump filename: c:\users\task_1538116560\appdata\local\temp\tmpgsq3mx.mozrunner\minidumps\762d7a20-fa89-4883-8858-c8a3854b48c5.dmp
06:54:45     INFO - Operating system: Windows NT
06:54:45     INFO -                   6.1.7601 Service Pack 1
06:54:45     INFO - CPU: x86
06:54:45     INFO -      GenuineIntel family 6 model 45 stepping 7
06:54:45     INFO -      8 CPUs
06:54:45     INFO - 
06:54:45     INFO - GPU: UNKNOWN
06:54:45     INFO - 
06:54:45     INFO - Crash reason:  EXCEPTION_BREAKPOINT
06:54:45     INFO - Crash address: 0x54b4bdec
06:54:45     INFO - Assertion: Unknown assertion type 0x00000000
06:54:45     INFO - Process uptime: 4 seconds
06:54:45     INFO - 
06:54:45     INFO - Thread 3 (crashed)
06:54:45     INFO -  0  xul.dll!nsThread::ProcessNextEvent(bool,bool *) [nsThread.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 1097 + 0x0]
06:54:45     INFO -     eip = 0x54b4bdec   esp = 0x021bf2e0   ebp = 0x021bf7e8   ebx = 0x021bf8a8
06:54:45     INFO -     esi = 0x021bf7ff   edi = 0x01197ca0   eax = 0x00000000   ecx = 0x00000000
06:54:45     INFO -     edx = 0x00000000   efl = 0x00000212
06:54:45     INFO -     Found by: given as instruction pointer in context
06:54:45     INFO -  1  xul.dll!NS_ProcessNextEvent(nsIThread *,bool) [nsThreadUtils.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 519 + 0x11]
06:54:45     INFO -     eip = 0x54b4e624   esp = 0x021bf7f0   ebp = 0x021bf80c
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  2  xul.dll!nsComponentManagerImpl::GetServiceByContractID(char const *,nsID const &,void * *) [nsComponentManager.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 1496 + 0xb]
06:54:45     INFO -     eip = 0x54b248e9   esp = 0x021bf814   ebp = 0x021bf864
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  3  xul.dll!nsGetServiceByContractID::operator()(nsID const &,void * *) [nsComponentManagerUtils.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 280 + 0x19]
06:54:45     INFO -     eip = 0x54b29f4d   esp = 0x021bf86c   ebp = 0x021bf880
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  4  xul.dll!static void WatchdogMain(void *) [XPCJSContext.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 530 + 0x1c]
06:54:45     INFO -     eip = 0x5563c086   esp = 0x021bf888   ebp = 0x021bf8c0
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  5  nss3.dll!_PR_NativeRunThread [pruthr.c:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 397 + 0x6]
06:54:45     INFO -     eip = 0x6384f185   esp = 0x021bf8c8   ebp = 0x021bf8e0
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  6  nss3.dll!static unsigned int pr_root(void *) [w95thred.c:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 137 + 0x7]
06:54:45     INFO -     eip = 0x6383e24d   esp = 0x021bf8e8   ebp = 0x021bf8ec
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  7  ucrtbase.dll!__RtlConvertUlongToLargeInteger + 0x7fe9
06:54:45     INFO -     eip = 0x6955e16f   esp = 0x021bf8f4   ebp = 0x021bf928
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  8  kernel32.dll!RtlMultiByteToUnicodeN + 0x73c
06:54:45     INFO -     eip = 0x77773c45   esp = 0x021bf930   ebp = 0x021bf934
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO -  9  mozglue.dll!static void patched_BaseThreadInitThunk(int, void *, void *) [WindowsDllBlocklist.cpp:2ba4c4ab35f5fd470d05a756adf3078a36960ddc : 701 + 0x41]
06:54:45     INFO -     eip = 0x69bc3854   esp = 0x021bf93c   ebp = 0x021bf978
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO - 10  ntdll.dll!__RtlUserThreadStart + 0x27
06:54:45     INFO -     eip = 0x77bc37f5   esp = 0x021bf980   ebp = 0x021bf9b8
06:54:45     INFO -     Found by: previous frame's frame pointer
06:54:45     INFO - 11  ntdll.dll!_RtlUserThreadStart + 0x1b
06:54:45     INFO -     eip = 0x77bc37c8   esp = 0x021bf9c0   ebp = 0x021bf9d0
06:54:45     INFO -     Found by: call frame info

This is failing on OSX, macosx and windows and since it's failing on different files, removing disable-recommended, adding needswork.
Whiteboard: [stockwell disable-recommended] → [stockwell needswork]
Kris, I can reproduce this ProfilerScreenshots crash every time when using the Gecko Profiler in Firefox 64 Nightly on macOS 10.14 Mojave. Should I file a new bug?

STR:
1. Install the Gecko Profiler.
2. In the profiler's toolbar menu, click the "Start" button.
3. In the profiler's toolbar menu, click the "Discard & Stop" button.

RESULT:
CRASH!

bp-ada1077f-cac7-46a1-8cdc-8d0640180929
bp-ba4e49aa-4b26-432d-a89b-3a5620180929
bp-61322f3c-1f36-4cfb-804d-f1eb00180929
Flags: needinfo?(kmaglione+bmo)
(In reply to Chris Peterson [:cpeterson] from comment #16)
> Kris, I can reproduce this ProfilerScreenshots crash every time when using
> the Gecko Profiler in Firefox 64 Nightly on macOS 10.14 Mojave. Should I
> file a new bug?

Yes, please.
Flags: needinfo?(kmaglione+bmo)
Depends on: 1495463
No occurrences in the last 7 days.
There are 8 total failures in the last 30 days.
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:other]

Other refactoring has changed the call sites for VRThread significantly and we haven't seen this crash for > 4 months. Would it still be beneficial to land these patches?

Flags: needinfo?(kmaglione+bmo)

Moving these bugs (intermittent test failures with crashes) out of P5.

Priority: P5 → --

I will be removing the affected code in Bug 1473402 and Bug 1466702, replacing it with a new VR puppet implementation that is more stable and representative of emulated hardware.

Depends on: 1473402, 1466702
Priority: -- → P2

The patch for Bug 1466702 has landed, re-implementing most of VRManager and related classes. The affected code has been rewritten.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Assignee: nobody → kmaglione+bmo
Assignee: kmaglione+bmo → kgilbert
Flags: needinfo?(kmaglione+bmo)
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.