1495463 - Gecko Profiler crash on macOS 10.14: [@ nsThread::ShutdownInternal | nsThread::Shutdown | mozilla::layers::ProfilerScreenshots::~ProfilerScreenshots ]

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Chris Peterson [:cpeterson]]

I can reproduce this ProfilerScreenshots crash every time when using the Gecko Profiler in Firefox 64 Nightly on macOS 10.14 Mojave.

STR:
1. Install the Gecko Profiler.
2. In the profiler's toolbar menu, click the "Start" button.
3. In the profiler's toolbar menu, click the "Discard & Stop" button.

RESULT:
CRASH!

bp-ada1077f-cac7-46a1-8cdc-8d0640180929
bp-ba4e49aa-4b26-432d-a89b-3a5620180929
bp-61322f3c-1f36-4cfb-804d-f1eb00180929

Comment 1

[Markus Stange [:mstange]]

This hits the release assert "Shutdown() may only be called from an XPCOM thread" which was added in bug 1494513.

And it's right - we're trying to shut down the ProfilerScreenshots thread from the compositor thread.

Kris, any ideas for how this should be done?

Comment 2

[Kris Maglione [:kmag]]

(In reply to Markus Stange [:mstange] from comment #1)
> This hits the release assert "Shutdown() may only be called from an XPCOM
> thread" which was added in bug 1494513.
> 
> And it's right - we're trying to shut down the ProfilerScreenshots thread
> from the compositor thread.
> 
> Kris, any ideas for how this should be done?

Dispatching a runnable to the main thread is probably your best bet.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1495463 - Shut down the ProfilerScreenshots thread from the main thread. r?kmag

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed764e9bab67
Shut down the ProfilerScreenshots thread from the main thread. r=kmag

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ed764e9bab67