1494665 - Treeherder no longer forwards to triggered interactive task

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As noticed today Treeherder no longer automatically opens a new tab for the interactive task as being created from the Treeherder UI. As Hassan mentioned this is a regression from bug 1470622.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4076

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 9012659 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4076

(wrong bug number)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4077

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f96bcb910ebb83b03c43cad7d1f92eabe05fca13
Bug 1494665 - Open interactive tasks in a new tab after triggering (#4077)

Comment 5

[Ed Morley [:emorley]]

This should be deployed to production later this week, but can be tested on stage (https://treeherder.allizom.org) in the meantime once it's auto-deployed (~15-20 mins).

Comment 6

[Hassan Ali (:hassan)]

https://github.com/mozilla/treeherder/pull/4077#issuecomment-425909898

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4088

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8a9375675ebed135c6ba560346a07878bd047a87
Revert "Bug 1494665 - Open interactive tasks in a new tab after triggering (#4077)" (#4088)

This reverts commit f96bcb910ebb83b03c43cad7d1f92eabe05fca13.

Comment 9

[Hassan Ali (:hassan)]

This change was reverted because it was redirecting to the action task instead of the interactive task. It turns out we don't have a way to know the task ID of the interactive task until the action task runs. The driver for all of this action stuff is this security requirement to reduce the scopes given to individual users, so it's natural to expect some reduction in usability in the process. You can see the full discussion in [1].

[1] https://github.com/mozilla/treeherder/pull/4077#issuecomment-425909898