1470622 - Convert actions performed manually by Treeherder to use hook-based actions

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

* retrigger (note that circular-arrow button only uses buildapi??)
* create interactive (just opens https://tools.taskcluster.net/tasks/<taskId>/interactive in a new window)
* edit & retrigger (just opens task editor)
* cancel

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #1)
> * retrigger (note that circular-arrow button only uses buildapi??)

This action already exists

> * create interactive

I need to write an action for this

> * edit & retrigger

We probably won't support this anymore..

> * cancel

I need to write an action for this.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

OK, Hassan, I think this is ready to go.  Basically we want to remove anything that calls any Taskcluster API functions other than triggerHook, replacing it with the appropriate action (or, for edit & retrigger, removing it entirely).  The "r" key and the "circular arrow" are sort of hidden, but should use the retrigger action, too.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Screenshot_2018-07-05 [4] autoland.png

(this is what I mean by "circular arrow")

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #2)
> > * create interactive
> 
> I need to write an action for this

Bug 1487444.

> > * edit & retrigger
> 
> We probably won't support this anymore..

*definitely* won't support this anymore

> > * cancel
> 
> I need to write an action for this.

This exists -- cancel.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3980

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 9006342 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3980

Cameron will be a better reviewer for this than I :-)

Comment 8

[Cameron Dawson [:camd]]

Comment on attachment 9006342 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3980

Just a few things.  Please reassign when you've made changes.  Thanks!

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c8998982cbe8bafb750948f9ce113d8b8e9342ca
Bug 1470622 - Convert actions to use hook-based actions (#3980)

* Convert pinboard actions to use hook-based actions

* Convert action bar actions to use hook-based actions

* Make create interactive task use hook-based actions

* Convert a second cancel-all to use hook-based actions

* Use hook-based actions for creating interactive tasks

* Remove angular $timeout, $apply

* Abstract away retrigger & cancel functions

* Remove thBuildApi entirely

* Remove PushModel.cancelAll and use actions json instead

* Remove usage of actions.yml

ESR52 still uses actions.yml but it is being treated as EOL
(Treeherder's buildbot ingestion has just been switched off).

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

I think this is done, judging by the uptick in number of action tasks being run over the last half-week :)

Comment 11

[Jorg K (CEST = GMT+2)]

Hmm, I was told that this was the bug for not being about to cancel and repeat jobs via TreeHerder. On the C-C Treeherder I tried cancelling jobs today and got errors. I've just tried to repeat a job and got:

Taskcluster: While firing hook: InterpreterError at template.payload.env[2]["ACTION_TASK"]: unknown context value task --- * method: triggerHook * errorCode: InputError * statusCode: 400 * time: 2018-09-18T17:21:24.776Z

Comment 12

[Jorg K (CEST = GMT+2)]

Filed bug 1492219 for that, sorry about the noise.

Comment 13

[Ed Morley [:emorley]]

Hi! I noticed that CustomJobActions is still using js-yaml -- is this a leftover from the actions.yml era that could be converted too? ie:
https://github.com/mozilla/treeherder/blob/692c35ddb2b239b2ec932b12fa013db9d9f21911/ui/job-view/CustomJobActions.jsx#L70-L139

If so, I'll file a new bug for that.

Comment 14

[Hassan Ali (:hassan)]

Now that we are using taskcluster for the other actions, I wonder if we really do need the custom taskcluster job actions modal anymore. Dustin, would it be safe to remove the "Custom Action..." button?

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

That is definitely still needed, for cases where people want to run actions that aren't hard-wired to some button in treeherder.  It uses YAML for display, even though the actions.json it's parsing is in JSON.  So it's not the old actions.yml stuff.

Comment 16

[Ed Morley [:emorley]]

Ok thank you. Perhaps once I've upgraded us to webpack 4 (via Neutrino 9), we can use code-splitting to reduce the impact of the feature on bundle size (js-yaml and ajv are very heavyweight: https://bundlephobia.com/result?p=js-yaml@3.12.0 and https://bundlephobia.com/result?p=ajv@6.5.3).

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

:emorley, I just tried a cancel all and got dozens of cx action tasks and so slow that hundreds of jobs started running: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2cf9384353062ec3c4f702e806dd571de15785a

this bug has a r- but is marked as fixed, I am not sure if we resolved this?

Comment 18

[Ed Morley [:emorley]]

Hi! The PR linked to this bug was merged ('merged' status in GitHub; commit link in comment 9) - but the review flag wasn't updated here after the final review on GitHub (our code reviews happen primarily on GitHub - if it wasn't for the handy Bugzilla reminder emails etc, we'd drop the Bugzilla review flag setting entirely). I'll update the flag now to avoid future confusion :-)

Regarding the behaviour you're seeing - could you file a new bug and mark it blocking this one? I'm not sure whether it would require changes on the taskcluster or treeherder side at this point. By "so slow" do you mean on the UI side making the API calls, or once the cancellation jobs had already been scheduled?