1494675 - Remove the AllocationHandle API

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Paul Adenot (:padenot)]

This is a followup from bug 1487057 part 3, pehrsons wrote in the review:

> We should get a bug on file to kill AllocationHandles and clean up the APIs using it.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1494675 - Remove MediaEngineSource::RequiresSharing. r?padenot

Sources are no longer shared.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1494675 - Remove AllocationHandle. r?padenot

The handle was used to keep separate allocations of the same source in a single
process apart. Sources no longer use sharing, so we no longer need allocations
or their handles even as a concept.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1494675 - Remove windowID to MediaEngineSource mappings from MediaEngines. r?padenot

These once served a caching-and-reuse purpose it seems, but it makes less sense
when sources are not shared.

There seems to still be functioning code to re-use fake audio devices, but this
seems like premature optimization. Especially since we don't care much about
fake devices in release.

This patch removes it all, together with some plumbing around the mechanism.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1494675 - Fix remaining static-analysis warnings in dom/media/webrtc. r?jib

Bug 1538113 fixed most, but apparently some remained. Unclear why -- perhaps I
ran it with a different config this time.

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1494675 - Merge SourceListener::Remove into SourceListener::Stop. r?padenot

Depends on: D24903

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e7832fee028
Remove MediaEngineSource::RequiresSharing. r=padenot
https://hg.mozilla.org/integration/autoland/rev/20543d03a4cd
Remove AllocationHandle. r=padenot
https://hg.mozilla.org/integration/autoland/rev/1248d2f659a9
Remove windowID to MediaEngineSource mappings from MediaEngines. r=padenot
https://hg.mozilla.org/integration/autoland/rev/276622dfadd8
Fix remaining static-analysis warnings in dom/media/webrtc. r=jib
https://hg.mozilla.org/integration/autoland/rev/be0fbe76851f
Merge SourceListener::Remove into SourceListener::Stop. r=padenot

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9e7832fee028
https://hg.mozilla.org/mozilla-central/rev/20543d03a4cd
https://hg.mozilla.org/mozilla-central/rev/1248d2f659a9
https://hg.mozilla.org/mozilla-central/rev/276622dfadd8
https://hg.mozilla.org/mozilla-central/rev/be0fbe76851f