Closed Bug 1494739 Opened Last year Closed Last year
Remove GV's VIBRATE permission requirement
Focus+WebView does not require the VIBRATE permission, so adding this permission in Focus+GV may require users to click through a permission prompt when updating to Focus+GV. Jim, can you take a look at this bug this week for GV 62 in Focus 7.0? James says we can remove the VIBRATE permission from GV's AndroidManifest.xml and let GV-powered apps choose whether they want to add the VIBRATE permission to their own AndroidManifest.xml. https://searchfox.org/mozilla-central/rev/de7676288a78b70d2b9927c79493adbf294faad5/mobile/android/geckoview/src/main/AndroidManifest.xml#9 Similarly, James is investigating whether we can remove the new ACCESS_WIFI_STATE permission in bug 1491094. These two permissions are the only new permissions that cause Android to prompt the user for permission when updating to Focus+GV: https://github.com/mozilla-mobile/focus-android/issues/3441
Yeah I think we can just remove that line (and maybe make sure calling the vibrate API doesn't cause a crash).
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Rmove the VIBRATE permission. GV actually doesn't support the vibration API at the moment, so the permission is unused anyways.
Attachment #9012942 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef59246c49b8 Remove GV vibrate permission; r=me
Comment on attachment 9012942 [details] [diff] [review] Remove GV vibrate permission (v1) Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: Focus needs this permission removed to not disrupt updates; GV doesn't use this permission anyways so removing it has no impact. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Removed permission is not actually used by GV. (It's used by Fennec but Fennec declares the permission separately) [String changes made/needed]: None
Attachment #9012942 - Flags: approval-mozilla-beta?
Uplifted to GV62 branch: https://hg.mozilla.org/releases/mozilla-release/rev/7f2d67c5d804f70414782f72d82ea7db15455d9a
Comment on attachment 9012942 [details] [diff] [review] Remove GV vibrate permission (v1) No impact on Fennec, uplift accepted for 63 beta 11, thanks.
Attachment #9012942 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 9012942 [details] [diff] [review] Remove GV vibrate permission (v1) Retroactively setting the GV62 approval flag.
Attachment #9012942 - Flags: approval-mozilla-geckoview62+
You need to log in before you can comment on or make changes to this bug.