Closed Bug 1494739 Opened Last year Closed Last year

Remove GV's VIBRATE permission requirement

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
Android
enhancement

Tracking

(geckoview62 fixed, firefox-esr60 unaffected, firefox62 wontfix, firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
geckoview62 --- fixed
firefox-esr60 --- unaffected
firefox62 --- wontfix
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: cpeterson, Assigned: jchen)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Focus+WebView does not require the VIBRATE permission, so adding this permission in Focus+GV may require users to click through a permission prompt when updating to Focus+GV.

Jim, can you take a look at this bug this week for GV 62 in Focus 7.0?

James says we can remove the VIBRATE permission from GV's AndroidManifest.xml and let GV-powered apps choose whether they want to add the VIBRATE permission to their own AndroidManifest.xml.

https://searchfox.org/mozilla-central/rev/de7676288a78b70d2b9927c79493adbf294faad5/mobile/android/geckoview/src/main/AndroidManifest.xml#9

Similarly, James is investigating whether we can remove the new ACCESS_WIFI_STATE permission in bug 1491094. These two permissions are the only new permissions that cause Android to prompt the user for permission when updating to Focus+GV:

https://github.com/mozilla-mobile/focus-android/issues/3441
Flags: needinfo?(nchen)
Yeah I think we can just remove that line (and maybe make sure calling the vibrate API doesn't cause a crash).
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Rmove the VIBRATE permission. GV actually doesn't support the vibration
API at the moment, so the permission is unused anyways.
Attachment #9012942 - Flags: review+
Comment on attachment 9012942 [details] [diff] [review]
Remove GV vibrate permission (v1)

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Focus needs this permission removed to not disrupt updates; GV doesn't use this permission anyways so removing it has no impact.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Removed permission is not actually used by GV. (It's used by Fennec but Fennec declares the permission separately)
[String changes made/needed]: None
Attachment #9012942 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/ef59246c49b8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9012942 [details] [diff] [review]
Remove GV vibrate permission (v1)

No impact on Fennec, uplift accepted for 63 beta 11, thanks.
Attachment #9012942 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 9012942 [details] [diff] [review]
Remove GV vibrate permission (v1)

Retroactively setting the GV62 approval flag.
Attachment #9012942 - Flags: approval-mozilla-geckoview62+
Depends on: 1495452
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.