149495 - Multiline notes on addressbook entries show on single line

Status: VERIFIED DUPLICATE of bug 16408

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[scott]

Steps to reproduce:
Create (or edit) an addressbook entry.
Go to the "other tab"
Enter a multi-line Comment in the notes field.
Click Ok

Expected Behavior:
vCard view should show comment under "other" spanning multiple wrapping lines.

Actual Behavior:
vCard view shows comment on single line, wrapping.

Comment 1

[scott]

Attachment: Proposed patch fixing multiline bug

This patch fixes the problem - adds a br after each line.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

confirming (no dups found)

racham, can you review this patch?

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 86554 [details] [diff] [review]
Proposed patch fixing multiline bug

I don't know enough about the GUI/DOM issues in this code to do the
module-owner review, so you'll have to get that from bhuvan/sspitzer,
I think.  However, I see several minor issues which do need to be
dealt with:

a) is splitting on \n going to be sufficient for all platforms (and
not just for local addrbook data, but also stuff coming from the
network, like LDAP)?  Or do we need to look at multiple possibilities
like \n || \r || \r\n ?  (I don't know the answer to this question;
sspitzer or bhuvan might).

b) please turn on JS strict warnings in the debug preference panel and
be sure this patch doesn't add any new warnings.  One thing I think
this will catch is that "var i" is declared twice in this function
(there is no concept of block scope in JS).

c) I think "if (card.notes.length > 0)" can really just be "if
(card.notes.length)", since length should never be negative, as far as
I know.

Anyway, this is just nitpicking; looks good in general.

Comment 4

[jglick]

Dup of bug 16408.

*** This bug has been marked as a duplicate of 16408 ***

Comment 5

[Vedran Miletic]

v