16408 - Multi-line notes in AB (addressbook) entries show as single line in Card View pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[esther]

Using 19991013m11 build on win32 only, pressing <Enter> to move to the next line
of the Notes area of a Card dialog displays as squares in the Card View Pane
on Windows and on windows and linux displays all (3) lines on the same line.
Note this does not happen in New Msg compose window in either HTML or Plain text
editing.  The second part of this bug about all three lines displaying on one
line is true for Linux too.

1. Launch Address book
2. Select Personal Address Book
3. Select a Card and click Edit
4. Select the Options tab
5. Get focus in Notes area and type "line 1" then press <Enter> to move to the
next line, type "line 2", then press <Enter> again to move to the 3rd line and
type "line 3".  OK the card
6. View the card in the Card View pane

Result:  Notice there is a square between line 1, line 2 and line 3.   Also,
line 1, line 2 and line 3 are not displayed on separate lines.
Expected: line 1, line 2 and line3 to be displayed in the Card view pane under
the Options heading each on a separate line and no extra characters added to the
end of the typed line

Comment 1

[hangas]

Mass move to M13.

Comment 2

[hangas]

Is this still a problem?  This should have been fixed with some of the text input 
field fixes over the last few months.

Comment 3

[hangas]

Mass moving to M17

Comment 4

[selmer (gone)]

Not beta2 stopper. Marking M18.  Add beta2 keyword if you disagree.

Comment 5

[hangas]

Mass move mailnews bugs to Putterman.  Ouch.

Comment 6

[lchiang]

Luis - can you see if still a problem on Windows and on Linux in latest builds?

Comment 7

[scottputterman]

this is no longer happening.  Marking WORKSFORME.

Comment 8

[esther]

Using build 2000-08-28 on win98, mac and linux the "square boxes" between Line1,
Line2 and Line 3 are gone, but all text is displayed on the same line instead of
on 3 separate lines.  In other words the carriage return is not a carriage
return Reopening for review.

Comment 9

[scottputterman]

reassigning to chuang.

Comment 10

[Oliver Klee]

Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.

Comment 11

[fenella]

QA-assign-to fenella.

Comment 12

[fenella]

The problem described by Esther still exists in the followings builds
Linux (2001-03-09-10 mtrunk)
Win32 (2001-03-09-06 mtrunk)
Mac (2001-03-08-10 mtrunk)

Comment 13

[scottputterman]

reassigning to racham

Comment 14

[racham]

We need to check on this one. 

Ninoschka, is this still happening..? thanks.

Comment 15

[Ninoschka Baca]

Bug# 109405 blocks me from testing this because when the Enter key is pressed it
closes the dialog.

Comment 16

[Ninoschka Baca]

Bhuvan, the bug that I said was blocking me has nothing to do with this bug 
becuase it references a list window. This bug is about the Edit Card dialog. 

If I press Enter in the Notes area then it closes the Edit Card dialog but if I 
press Shift+Enter then it does advance to the next line. Using this workaround I 
created notes on 4 separate lines and when the dialog is closed the Card Pane 
displays the notes as one contiguous line. If I open the card then the notes 
appear on 4 separate lines so the problem appears in the Card Pane.

Expected Results: The Card Pane should display the same format as the Notes 
section in the Edit Card dialog.

Comment 17

[jglick]

Still valid with 2002122608 windows build.

Comment 18

[jglick]

*** Bug 149495 has been marked as a duplicate of this bug. ***

Comment 19

[jglick]

*** Bug 115908 has been marked as a duplicate of this bug. ***

Comment 20

[jglick]

bug 149495 has a patch attached but its been sitting since 6/02.

Comment 21

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 22

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 23

[Wolfgang Preuss]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040725
The hint in comment #16 doesn't work anymore since some time.
Formerly separated lines in the notes section of an address card
appear now without any separation.

Comment 24

[Wolfgang Preuss]

I just installed
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040823
and found that this problem seems to be fixed at least in my environment.
Using the normal Enter key as well as Shift+Enter in the notes area result
now in a new line as expected.
Thanks,  Wolfgang

Comment 25

[Piotr Majdak]

With ENTER separated lines in Edit Card/Other/Notes appear separated in the edit
view but appear in one line in the card view.

Comment 26

[Piotr Majdak]

I forgot: Mozilla 1.7b

Comment 27

[Mark Banner (:standard8)]

Attachment: Potential Fix

This patch adds in the handling for multi-line notes in the cards. There is
also an additional fix that stops flickering whilst the card is being redrawn
(basically hide it before we set up all the values again, then display it).

There is one issue to clear up with display problems (scrollbars appearing when
not needed) that I will talk to someone with more knowledge later, once I can
resolve that I should be able to set the review flags.

Comment 28

[Mark Banner (:standard8)]

*** Bug 214822 has been marked as a duplicate of this bug. ***

Comment 29

[Mark Banner (:standard8)]

Attachment: Patch to enable proper viewing of multiline notes.

Revised patch to just fix the problem - the flicker is now not that bad and
isn't the subject of this patch.

One line fix for multi-line comments.

Comment 30

[[e-mail]]

Comment on attachment 169459 [details] [diff] [review]
Patch to enable proper viewing of multiline notes.

Nit: semicolon at the end of the style please.

Comment 31

[Mark Banner (:standard8)]

Attachment: Revised patch to fix nit

Revised to fix nit - requesting sr approval.

Comment 32

[Mark Banner (:standard8)]

Sorry for spam, forgot to note that I'm "borrowing" neil's r.

Comment 33

[Mark Banner (:standard8)]

David, any chance of an SR on this one-line patch sometime? Thanks.

Comment 34

[David :Bienvenu]

Comment on attachment 169468 [details] [diff] [review]
Revised patch to fix nit

sure, sorry, missed this (sometimes my ISP marks bugzilla mail as spam)

Comment 35

[Mark Banner (:standard8)]

Fix checked in, marking as fixed.
2005-01-15 01:52	db48x%yahoo.com 	mozilla/ mailnews/ addrbook/ resources/
content/ abCardViewOverlay.xul 	1.37 	1/1 

Comment 36

[Stephen Donner [:stephend] Not actively reading bugmail]

The problems described in comment 8 and comment 16 are gone.

Verified FIXED using build 2005-07-10-05 on Windows XP SeaMonkey trunk.