Closed Bug 1495035 Opened 6 years ago Closed 6 years ago

take product versions into account for msi, exe and zip installs/downloads

Categories

(Infrastructure & Operations :: RelOps: OpenCloudConfig, task)

Unspecified
Windows
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: grenade, Assigned: grenade)

References

Details

Attachments

(1 file)

when we download files as part of an MsiInstall (or ExeInstall or ZipInstall) we don't check that the file we want to download doesn't already exist on the filesystem. on ec2 this would rarely cause a problem but on hardware, where the filesystem can outlive some product upgrades, it's a bug. i'll need to write a patch that takes updates or version numbers into account for msi, exe and zip files.
Attached file GitHub Pull Request
this pr - adds the unique product id to the filename of the downloaded msi file - adds the sha 512 hash to the filename of the downloaded zip or exe file this prevents creating files with the same name when an installer is upgraded to a newer version.
Attachment #9013337 - Flags: review?(mcornmesser)
Attachment #9013337 - Flags: review?(mcornmesser) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This got backed out in bug 1496526.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also: → 1496526
the backout was backed out too. full explanation of what happened in bug 1496526, comment 4.
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: