1495069 - 2.73 - 6% sessionrestore / sessionrestore_no_auto_restore regression on push 126409bdf326 (Wed Sep 26 2018)

Status: RESOLVED WONTFIX

(Testing :: Talos, defect)

Description

[Andrew Swan [:aswan]]

+++ This bug was initially created as a clone of Bug #1494882 +++

[Peeling off just the sessionrestore regressions from the original bug]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1b268215517c906a22e5341b3978f5b551e92328&tochange=126409bdf326645e735ee147bd70bd7d09759165

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  6%  sessionrestore windows10-64 opt e10s stylo                     288.50 -> 305.58
  5%  sessionrestore_no_auto_restore windows10-64 pgo e10s stylo     287.88 -> 301.42
  5%  sessionrestore_no_auto_restore windows10-64 opt e10s stylo     314.12 -> 328.67
  5%  sessionrestore_no_auto_restore windows7-32 opt e10s stylo      318.92 -> 333.42
  4%  sessionrestore windows7-32 opt e10s stylo                      300.42 -> 313.67
  4%  sessionrestore windows10-64 pgo e10s stylo                     268.42 -> 278.92
  4%  sessionrestore windows7-32 pgo e10s stylo                      277.00 -> 287.58
  3%  sessionrestore_no_auto_restore windows7-32 pgo e10s stylo      297.71 -> 305.83

Comment 1

[Andrew Swan [:aswan]]

Florian, do you have any interest in looking at this?  I think https://bugzilla.mozilla.org/show_bug.cgi?id=1492519#c6 may also be relevant.

Comment 2

[Ionuț Goldan [:igoldan]]

ni? :florian, based on comment 1.

Comment 3

[Ionuț Goldan [:igoldan]]

:vchin we need your help on concluding this bug, as it's >2 weeks since it got stuck. FYI, this is about a performance test issue, not a Firefox one.

Comment 4

[Vicky Chin [:vchin]]

I'm not familiar with the performance test in question. +Dave Hunt

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

given that this is a test change, I would mark this as infra- if we want to do a deeper dive and investigate where sessionrestore test is measuring and if it is measuring the right things, this might be good data to keep in mind.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

err, when I say infra- I mean, resolved::wontfix

Comment 7

[Ionuț Goldan [:igoldan]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #5)
> given that this is a test change, I would mark this as infra- if we want to
> do a deeper dive and investigate where sessionrestore test is measuring and
> if it is measuring the right things, this might be good data to keep in mind.

I see bug 1504133 landed; it addressed the problems we saw with the sessionrestore tests. Thus, I'd close this bug as WONTFIX.

Comment 8

[Ionuț Goldan [:igoldan]]

Removing ni? based on comment 7.