1493867 - Convert pageloader and talos-powers to webextensions

Status: RESOLVED FIXED

(Testing :: Talos, enhancement, P1)

Description

[Andrew Swan [:aswan]]

Peeling off part of bug 1451522 to make this more incremental than converting everything in Talos in one go.  The two extensions to be handled in this bug are the general purpose helpers used for all Talos tests, once they are converted we can convert the remain test-specific extensions individually.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1493867 Convert pageloader to a webextension

This is more than just a simple packaging conversion, this patch also
rips out the usage of nsICommandLineHandler.  A side effect of that
change is that it became much trickier for the extension to tell if it
should be active or not, that is addressed by having the test harness
explicitly set an environment variable rather than inferring from the
command line arguments what should happen.

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1493867 Convert talos-powers to a webextension

Most of the changed lines in the patch are a result of moving resources
from this extension from chrome: to resource: URLs.  The more significant
change lurking behind that one is that the webextension api.js file is
loaded asynchronously so it does not run as early in startup as bootstrap.js
used to run.  This causes races for some of the users of talos powers,
these are addressed by adding a simple ping-pong exchange that talos powers
consumers can use to ensure that the extension is fully initialized before
trying to use its features.

Comment 3

[Andrew Swan [:aswan]]

Try run is here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14ca9128bcc4fa324edd40457217850e3e5e6c24

The failures in damp are bug 1492867

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9012001 [details]
Bug 1493867 Convert pageloader to a webextension

Mike Conley (:mconley) (:⚙️) has approved the revision.

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 9012001 [details]
Bug 1493867 Convert pageloader to a webextension

Robert Wood [:rwood] has approved the revision.

Comment 6

[Robert Wood [:rwood]]

Comment on attachment 9012002 [details]
Bug 1493867 Convert talos-powers to a webextension

Robert Wood [:rwood] has approved the revision.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9012002 [details]
Bug 1493867 Convert talos-powers to a webextension

Mike Conley (:mconley) (:⚙️) has approved the revision.

Comment 8

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55504662325dcb713ec9d5bdda8d5295d338c19c
Bug 1493867 Convert pageloader to a webextension

https://hg.mozilla.org/integration/mozilla-inbound/rev/126409bdf326645e735ee147bd70bd7d09759165
Bug 1493867 Convert talos-powers to a webextension

Comment 9

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6da5272fc16ca57d30e4164c406942dac18af10
Bug 1493867 follow-up: avoid loading firstrun page during damp tests r=kmag

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/55504662325d
https://hg.mozilla.org/mozilla-central/rev/126409bdf326

Comment 11

[Ionuț Goldan [:igoldan]]

This updated at least one of our baselines:

== Change summary for alert #16183 (as of Wed, 26 Sep 2018 17:24:42 GMT) ==

Improvements:

  5%  tart linux64-qr opt e10s stylo     4.29 -> 4.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16183

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d6da5272fc16