Closed Bug 1493867 Opened 4 years ago Closed 4 years ago

Convert pageloader and talos-powers to webextensions

Categories

(Testing :: Talos, enhancement, P1)

Version 3
enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: aswan, Assigned: aswan)

References

Details

Attachments

(2 files)

Peeling off part of bug 1451522 to make this more incremental than converting everything in Talos in one go.  The two extensions to be handled in this bug are the general purpose helpers used for all Talos tests, once they are converted we can convert the remain test-specific extensions individually.
This is more than just a simple packaging conversion, this patch also
rips out the usage of nsICommandLineHandler.  A side effect of that
change is that it became much trickier for the extension to tell if it
should be active or not, that is addressed by having the test harness
explicitly set an environment variable rather than inferring from the
command line arguments what should happen.
Attachment #9012001 - Attachment is obsolete: true
Most of the changed lines in the patch are a result of moving resources
from this extension from chrome: to resource: URLs.  The more significant
change lurking behind that one is that the webextension api.js file is
loaded asynchronously so it does not run as early in startup as bootstrap.js
used to run.  This causes races for some of the users of talos powers,
these are addressed by adding a simple ping-pong exchange that talos powers
consumers can use to ensure that the extension is fully initialized before
trying to use its features.
Attachment #9012001 - Attachment is obsolete: false
Comment on attachment 9012001 [details]
Bug 1493867 Convert pageloader to a webextension

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9012001 - Flags: review+
Comment on attachment 9012001 [details]
Bug 1493867 Convert pageloader to a webextension

Robert Wood [:rwood] has approved the revision.
Attachment #9012001 - Flags: review+
Comment on attachment 9012002 [details]
Bug 1493867 Convert talos-powers to a webextension

Robert Wood [:rwood] has approved the revision.
Attachment #9012002 - Flags: review+
Comment on attachment 9012002 [details]
Bug 1493867 Convert talos-powers to a webextension

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9012002 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6da5272fc16ca57d30e4164c406942dac18af10
Bug 1493867 follow-up: avoid loading firstrun page during damp tests r=kmag
https://hg.mozilla.org/mozilla-central/rev/55504662325d
https://hg.mozilla.org/mozilla-central/rev/126409bdf326
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
This updated at least one of our baselines:

== Change summary for alert #16183 (as of Wed, 26 Sep 2018 17:24:42 GMT) ==

Improvements:

  5%  tart linux64-qr opt e10s stylo     4.29 -> 4.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16183
Depends on: 1494882
Depends on: 1495065
Depends on: 1495068
Depends on: 1495069
See Also: → 1495310
See Also: → 1220362
You need to log in before you can comment on or make changes to this bug.