Wire up ESNI to NSS

RESOLVED FIXED in Firefox 64

Status

()

RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: ekr, Assigned: ekr)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-phabricator-request
dragana
: review+
Details | Review
Comment hidden (empty)
(Assignee)

Comment 1

4 months ago
Created attachment 9013012 [details]
Bug 1495120 - Wire up ESNI
Comment on attachment 9013012 [details]
Bug 1495120 - Wire up ESNI

Dragana Damjanovic [:dragana] has approved the revision.
Attachment #9013012 - Flags: review+

Comment 4

4 months ago
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/669ffcf8bc71
Backed out changeset d2edbb87f3d2 for bustages at /security/manager/ssl/nsNSSIOLayer.cpp on a CLOSED TREE
Backed out changeset d2edbb87f3d2 (bug 1495120) for bustages at /security/manager/ssl/nsNSSIOLayer.cpp on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/669ffcf8bc71befad54737c97b242059a80e8143

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&selectedJob=202314446&revision=d2edbb87f3d283ab2c2fb6f8ad3408f792a6bd27

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=202314446&repo=autoland&lineNumber=32553

Log snippet:

task 2018-09-28T22:49:58.702Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/security/generate_mapfile.py main out.smime.def .deps/out.smime.def.pp .deps/out.smime.def.stub /builds/worker/workspace/build/src/security/nss/lib/smime/smime.def
[task 2018-09-28T22:49:58.702Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/smime/smime_smime3'
[task 2018-09-28T22:49:58.702Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2018-09-28T22:49:58.703Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2018-09-28T22:49:58.703Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2018-09-28T22:49:58.703Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/xre'
[task 2018-09-28T22:49:58.708Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/smime/smime_smime3'
[task 2018-09-28T22:49:58.708Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/smime/smime_smime3'
[task 2018-09-28T22:49:58.737Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/gtest'
[task 2018-09-28T22:49:58.737Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-gnu -o ulpfec_receiver_unittest.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DHAVE_UINT64_T -DWEBRTC_POSIX -DWEBRTC_BUILD_LIBEVENT -DWEBRTC_LINUX -DGTEST_RELATIVE_PATH -DWEBRTC_APM_DEBUG_DUMP -DWEBRTC_INTELLIGIBILITY_ENHANCER=0 -DWEBRTC_MOZILLA_BUILD=1 -DUSE_X11 -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/media/webrtc/trunk/gtest -I/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/gtest -I/builds/worker/workspace/build/src/media/webrtc/trunk -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/media/libopus/celt -I/builds/worker/workspace/build/src/media/libopus/include -I/builds/worker/workspace/build/src/media/libopus/src -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/media/webrtc/trunk/third_party/gflags/gen/posix/include -I/builds/worker/workspace/build/src/media/webrtc/trunk/third_party/gflags/gen/posix/include/private -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow -Wno-inconsistent-missing-override -Wno-overloaded-virtual -Wno-comma  -MD -MP -MF .deps/ulpfec_receiver_unittest.o.pp   /builds/worker/workspace/build/src/media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc
[task 2018-09-28T22:49:58.737Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/gtest'
[task 2018-09-28T22:49:58.738Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/manager/ssl'
[task 2018-09-28T22:49:58.738Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-gnu -o Unified_cpp_security_manager_ssl2.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES=True -DNSS_ENABLE_ECC=True -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/security/manager/ssl -I/builds/worker/workspace/build/src/obj-firefox/security/manager/ssl -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/crypto -I/builds/worker/workspace/build/src/security/certverifier -I/builds/worker/workspace/build/src/security/pkix/include -I/builds/worker/workspace/build/src/obj-firefox/dist/public/nss -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter  -MD -MP -MF .deps/Unified_cpp_security_manager_ssl2.o.pp   /builds/worker/workspace/build/src/obj-firefox/security/manager/ssl/Unified_cpp_security_manager_ssl2.cpp
[task 2018-09-28T22:49:58.739Z] 22:49:58     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/security/manager/ssl/Unified_cpp_security_manager_ssl2.cpp:29:
[task 2018-09-28T22:49:58.739Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/security/manager/ssl/nsNSSIOLayer.cpp:1032:23: error: use of undeclared identifier 'SSL_EnableESNI'
[task 2018-09-28T22:49:58.739Z] 22:49:58     INFO -      if (SECSuccess != SSL_EnableESNI(mFd,
[task 2018-09-28T22:49:58.740Z] 22:49:58     INFO -                        ^
[task 2018-09-28T22:49:58.740Z] 22:49:58     INFO -  1 error generated.
[task 2018-09-28T22:49:58.740Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1129: recipe for target 'Unified_cpp_security_manager_ssl2.o' failed
[task 2018-09-28T22:49:58.741Z] 22:49:58     INFO -  make[4]: *** [Unified_cpp_security_manager_ssl2.o] Error 1
[task 2018-09-28T22:49:58.741Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/security/manager/ssl'
[task 2018-09-28T22:49:58.742Z] 22:49:58     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'security/manager/ssl/target' failed
[task 2018-09-28T22:49:58.742Z] 22:49:58     INFO -  make[3]: *** [security/manager/ssl/target] Error 2
[task 2018-09-28T22:49:58.743Z] 22:49:58     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-09-28T22:49:58.743Z] 22:49:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/gtest'
[task 2018-09-28T22:49:58.744Z] 22:49:58     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/trunk/gtest'
This should reland after Bug 1488622 reaches autoland.

Updated

4 months ago
Depends on: 1495221
https://hg.mozilla.org/mozilla-central/rev/4d786f9a4ba0
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee: nobody → ekr
You need to log in before you can comment on or make changes to this bug.