1495122 - Support regionCode and dependentLocality for merchant errors

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

We need to support these properties for errors.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1495122 - Support regionCode and dependentLocality for merchant errors. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3df92480890e
Support regionCode and dependentLocality for merchant errors. r=MattN

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 3df92480890e (Bug 1495122) as it was requested by the dev on irc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/081704356a93
Support regionCode and dependentLocality for merchant errors. r=MattN

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa108f29df87
Backed out changeset 3df92480890e as it was requested by the dev on irc

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for bc failures on browser_shippingaddresschange_error.js.

backout: https://hg.mozilla.org/integration/autoland/rev/eed15f1e00944954d89865708a7bf7e759fe3d50

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=212065802&revision=081704356a9370001159c8bed0d554b738d5c622

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212065802&repo=autoland&lineNumber=10905 

[task 2018-11-15T21:58:51.470Z] 21:58:51     INFO - TEST-PASS | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Field specific error should be associated with phone - "Only allowed to ship to area codes that start with 9" == "Only allowed to ship to area codes that start with 9" - 
[task 2018-11-15T21:58:51.471Z] 21:58:51     INFO - TEST-PASS | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Field specific error should be associated with postalCode - "Only allowed to ship to postalCodes that start with 0" == "Only allowed to ship to postalCodes that start with 0" - 
[task 2018-11-15T21:58:51.473Z] 21:58:51     INFO - TEST-PASS | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Field specific error should be associated with recipient - "Can only ship to names that start with J" == "Can only ship to names that start with J" - 
[task 2018-11-15T21:58:51.475Z] 21:58:51     INFO - Buffered messages finished
[task 2018-11-15T21:58:51.476Z] 21:58:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Field specific error should be associated with region - "Regions must be 1 to 3 characters in length (sometimes ;) )" == "Can only ship to regions that start with M Regions must be 1 to 3 characters in length (sometimes ;) )" - 
[task 2018-11-15T21:58:51.478Z] 21:58:51     INFO - Stack trace:
[task 2018-11-15T21:58:51.479Z] 21:58:51     INFO - resource://testing-common/content-task.js line 59 > eval:null:38
[task 2018-11-15T21:58:51.481Z] 21:58:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-15T21:58:51.482Z] 21:58:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Field specific error should be associated with regionCode - "Regions must be 1 to 3 characters in length (sometimes ;) )" == "Can only ship to regions that start with M Regions must be 1 to 3 characters in length (sometimes ;) )" - 
[task 2018-11-15T21:58:51.483Z] 21:58:51     INFO - Stack trace:
[task 2018-11-15T21:58:51.484Z] 21:58:51     INFO - resource://testing-common/content-task.js line 59 > eval:null:38
[task 2018-11-15T21:58:51.486Z] 21:58:51     INFO - setup updateWith to clear errors
[task 2018-11-15T21:58:51.487Z] 21:58:51     INFO - saving corrections
[task 2018-11-15T21:58:51.488Z] 21:58:51     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "resource://payments/paymentRequest.xhtml" line: 0}]
[task 2018-11-15T21:58:51.490Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 22 (0x7f3bc1fa8800) [pid = 3536] [serial = 127] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-11-15T21:58:51.491Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 21 (0x7f3bc24b6000) [pid = 3536] [serial = 129] [outer = (nil)] [url = about:blank]
[task 2018-11-15T21:58:51.492Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 20 (0x7f3bc24b9400) [pid = 3536] [serial = 123] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-11-15T21:58:51.493Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 19 (0x7f3bc3210400) [pid = 3536] [serial = 125] [outer = (nil)] [url = about:blank]
[task 2018-11-15T21:58:51.495Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 18 (0x7f3bc1c39800) [pid = 3536] [serial = 119] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-11-15T21:58:51.496Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 17 (0x7f3bc24ae400) [pid = 3536] [serial = 121] [outer = (nil)] [url = about:blank]
[task 2018-11-15T21:58:51.497Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 16 (0x7f3bc1fa1000) [pid = 3536] [serial = 117] [outer = (nil)] [url = about:blank]
[task 2018-11-15T21:58:51.498Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 15 (0x7f3bc1c35c00) [pid = 3536] [serial = 115] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-11-15T21:58:51.499Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 14 (0x7f3bc1c32c00) [pid = 3536] [serial = 111] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-11-15T21:58:51.501Z] 21:58:51     INFO - GECKO(3340) | --DOMWINDOW == 13 (0x7f3bc1c3ac00) [pid = 3536] [serial = 113] [outer = (nil)] [url = about:blank]
[task 2018-11-15T21:58:51.589Z] 21:58:51     INFO - TEST-PASS | browser/components/payments/test/browser/browser_shippingaddresschange_error.js | Error text should not be present on dialog - "" == "" -

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f799e4c3da
Support regionCode and dependentLocality for merchant errors. r=MattN

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/02f799e4c3da

Comment 9

[Hani Yacoub, Desktop QA]

I can't figure out how could I verify this one. Could you please provide some areas/steps how to verify it?
Thanks.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

I don't know of a way to manually verify this unless you write a webpage that uses these error values. This patch did include automated tests.