1481972 - Support all countries in form autofill preferences for use by Payment Request

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Matthew N. [:MattN]]

Even if we don't support Form Autofill outside of specific countries/regions for now, we should allow users to manually save addresses in preferences and the PaymentRequest dialog outside of those countries. This is necessary so that a user in a supported country isn't prevented from using an address outside of the supported countries and therefore having to use another browser.

This would include importing the other countries and regions in https://dxr.mozilla.org/mozilla-central/source/browser/extensions/formautofill/addressmetadata/addressReferences.js to get the proper form layout

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1481972 - Add remaining countries to address autofill countries list. r?MattN

It wasn't clear to me if we should be adding _all_ of these countries but I couldn't determine which countries to exlucde if we were to exlude any.

Also, the country dropdown is not showing the country name for: AC, AX, PS, SJ, TA, or UM.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Brian, this bug is adding a field for some regions that will be labeled for Villages or Townships (it's ambiguous in this case).

* Google Chrome labels this field as "Village / Township".
* I have proposed labeling this field as "Village or Township" to match our labeling of "Country or Region". MattN would prefer that we use "Village / Township" here and thinks that users won't expect this type of consistency between fields.

Can you help us decide what to label this field?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: load-all-regions2.js

script used to retrieve all address references, also sorting object keys

Comment 4

[Brian Jones]

Hmmmm. Interesting little wrinkle. The field will be a dropdown select? I'd prefer consistency (not sure there's difference between "V/T" and "V or T"...they're both unambiguous re: their intent), especially if user will be seeing both on same screen.

Comment 5

[Matthew N. [:MattN]]

(In reply to Brian Jones from comment #4)
> Hmmmm. Interesting little wrinkle. The field will be a dropdown select?

No, no dropdown in this case I don't think since there are probably a large number of Village / Township

> I'd
> prefer consistency (not sure there's difference between "V/T" and "V or
> T"...they're both unambiguous re: their intent), especially if user will be
> seeing both on same screen.

The "Country or Region" strings comes from https://wiki.mozilla.org/Lists_of_Countries_and_Regions so I'm not sure if we can change it or not but I find "or" on a field label unusual so that's why I asked.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29e7b5d5f5e4
Add remaining countries to address autofill countries list. r=MattN

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/29e7b5d5f5e4

Comment 8

[Brian Jones]

MattN, I'm with you re: "or" being a bit of an odd construction. If we can update both to "/" that would be my preference, but if not, we should be consistent.

Comment 9

[Hani Yacoub, Desktop QA]

For which countries "Village or Township" field could be displayed?

Comment 10

[Matthew N. [:MattN]]

(In reply to Hani Yacoub from comment #9)
> For which countries "Village or Township" field could be displayed?

Malaysia

Comment 11

[Hani Yacoub, Desktop QA]

I confirm that countries and regions from the user story link are displayed in save addresses in preferences and the PaymentRequest dialog.
I am not sure if we should log a bug to update both from "or" to "/" or the decision has not been taken yet?

Comment 12

[Matthew N. [:MattN]]

(In reply to Hani Yacoub from comment #11)
> I am not sure if we should log a bug to update both from "or" to "/" or the
> decision has not been taken yet?

Sure, I don't think it's a high priority given that the inconsistency is only affecting one country.