1495189 - Remove glyph-dropdown{,@2x}.png and replace usages with arrow-dropdown-12.svg

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Comment 1

[Irvin Ives Lau]

Hello, I'm new and I would like to work on this issue as my first bug.

Comment 2

[Manish [:manishkk]]

Sure! submit the patch. 
Later someone (:ntim) will assign this to you.
If this is your first bug check this also:
https://wiki.mozilla.org/Good_first_bug

Either you can submit patch here or you can submit using phabricator.

Comment 3

[Tim Nguyen :ntim]

(In reply to Irvin Ives Lau from comment #1)
> Hello, I'm new and I would like to work on this issue as my first bug.

Sure! Once you've set up everything, you'll need to:

- Remove these two files:
toolkit/themes/osx/global/icons/glyph-dropdown.png
toolkit/themes/osx/global/icons/[e-mail]

- Remove these lines:
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/browser/themes/osx/browser.css#790-799
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/browser/themes/osx/browser.css#833-842
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/toolkit/themes/osx/global/jar.mn#54-55

- And change these lines:

https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/browser/themes/osx/browser.css#831
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/browser/themes/osx/browser.css#785

to use arrow-dropdown-12.svg instead of glyph-dropdown.png

Once you've done all those steps, you can submit a patch, then I'll assign the bug to you.

Comment 4

[Manish [:manishkk]]

Irvin

If you need more information, you can ask in IRC #Introduction
or 
use "Need More Information from" feature here.

while submitting review also, tag someone, who can review your patch.

Comment 5

[Irvin Ives Lau]

Attachment: patch.diff

Hi, thank you for assigning me the task, I have made a patch.

Please kindly review this and let me know if it is okay.

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 9030790 [details] [diff] [review]
patch.diff

Review of attachment 9030790 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! It looks like you haven't removed the files in this patch.

Can you do:

hg rm toolkit/themes/osx/global/icons/glyph-dropdown.png

hg rm toolkit/themes/osx/global/icons/[e-mail]

from your terminal ?

::: browser/themes/osx/browser.css
@@ +782,4 @@
>  
>  button.translate-infobar-element.options-menu-button > .button-box > .button-menu-dropmarker {
>    display: -moz-box;
> +  list-style-image: url("chrome://../shared/icons/arrow-dropdown-12.svg");

This should be chrome://global/skin/icons/arrow-dropdown-12.svg

@@ +818,4 @@
>  
>  menulist.translate-infobar-element > .menulist-dropmarker {
>    display: -moz-box;
> +  list-style-image: url("chrome://../shared/icons/arrow-dropdown-12.svg");

Same here

Comment 7

[Irvin Ives Lau]

Attachment: patch.diff

Thank you for your review, I have now made the changes.

Please let me know if it's fine.

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 9030809 [details] [diff] [review]
patch.diff

Review of attachment 9030809 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc5588a9a19
Remove glyph-dropdown{,@2x}.png and replace usages with arrow-dropdown-12.svg. r=jaws

Comment 10

[Tim Nguyen :ntim]

Thanks for working on this Irvin! Bug 1509634 is pretty similar if you're looking for more bugs :)

Comment 11

[Irvin Ives Lau]

Thank you for your guidance, I will definitely check it out!

(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #10)
> Thanks for working on this Irvin! Bug 1509634 is pretty similar if you're
> looking for more bugs :)

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fcc5588a9a19