1495242 - Webrender Inspector memory leak

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Anton Lazarev]

Attachment: webrender-leak.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20180905123750

Steps to reproduce:

Using Nightly 64.0a1.

1. Set gfx.webrender.all to "true" in about:config
2. Open the attached HTML file (which is just a few empty div elements)
3. Open the Inspector in the Web Developer tools and expand the body element so that the empty divs are visible
4. Move the mouse cursor up and down over the div elements repeatedly


Actual results:

Memory usage increases at a fairly constant rate while mousing over elements. On my machine, about 130MB is allocated for each pass over the entire list of elements.
Closing the Web Developer tools or even the tab itself does not free the newly allocated memory.


Expected results:

Hovering over elements in the Inspector should not cause memory leakage. Behavior should be consistent with when gfx.webrender.all is set to "false".

Comment 1

[Darkspirit]

Thanks you! But you need to update your Nightly. ;)

mozregression --good 2018-06-15 --bad 20180905123750 --pref gfx.webrender.all:true -a https://bug1495242.bmoattachments.org/attachment.cgi?id=9013112
> 8:38.92 INFO: Last good revision: 8984f6868e572079cc991492124ba99747f0f681
> 8:38.92 INFO: First bad revision: 80efe717b563f329a2261a8d23f4ebbc470c432f
> 8:38.92 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8984f6868e572079cc991492124ba99747f0f681&tochange=80efe717b563f329a2261a8d23f4ebbc470c432f

> 80efe717b563	Nicolas Silva — Bug 1455422 - Implement the new blob image rasterization hooks. r=kats, gankro
> 7041b2f0aef8	Jeff Muizelaar — Bug 1476636. Update Cargo lockfiles, re-vendor rust dependencies
> 5fdc7f00aba1	Jeff Muizelaar — Bug 1476636. Update webrender to commit 9f21ee5dba0694818a1e2e46d95734ede281447c


mozregression --find-fix --bad 20180905123750 --good 2018-09-29 --pref gfx.webrender.all:true -a https://bug1495242.bmoattachments.org/attachment.cgi?id=9013112
> 13:13.13 INFO: First good revision: ada6c9fc290cbf335597c6f435eb9e961bda603c
> 13:13.13 INFO: Last bad revision: 5d90cbaeceb8b76ff4e2a6707aef34e24cdb8361
> 13:13.13 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5d90cbaeceb8b76ff4e2a6707aef34e24cdb8361&tochange=ada6c9fc290cbf335597c6f435eb9e961bda603c

> ada6c9fc290c	Lee Salzman — Bug 1480615 - reuse scaled fonts across blob image recordings. r=jrmuizel

Comment 2

[Darkspirit]

Thank you*