1476636 - Update webrender to 9f21ee5dba0694818a1e2e46d95734ede281447c

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1475252 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1475252#c5:

WR @ 41ceda1754a950bcc2127059ab1dff728eb40ab6

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04c6bc71074245fa9d8438a78922e71fbd36dff7

That has some panics, regression range is:

*   41ceda17 Auto merge of #2907 - servo:gleam, r=nical
|\
| * 6d3fa14f (origin/gleam) Update gleam to 0.6
* |   e6635df8 Auto merge of #2905 - gw3583:cpu-opt, r=kvark
|\ \
| |/
|/|
| * d40a73dd Remove some redundant rectangle transform and union code.
*   89c79c22 Auto merge of #2903 - zakorgy:winit-dpi, r=kvark
|\
| * 23d3cae5 Use dpi from winit instead of glutin
* 9117f291 Auto merge of #2904 - Eijebong:euclid, r=nical
* 29033572 Bump rust's version to fix tests
* 2a6676d0 Update euclid to 0.18

I'm doing more try pushes to narrow it down:
@ 89c79c22 -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3a6f5bf0f4c98e38b3a355a6e5adbd254d99336
@ e6635df8 -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=74acfeaced6d334aa71ee2912c806a775f6d4cb1

Comment 2

[Kartikaya Gupta (email:[e-mail])]

@ 88dab3f61 -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=58c7393693acac3b3787cc2a37abb441ddeddb50
@ 9117f2913 -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae395ed26643f77eb491f96d7cf9c8d05ed22d1e

Comment 3

[Kartikaya Gupta (email:[e-mail])]

So the panics are coming from servo/webrender#2904

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 3baeb234fee723a9bb6a902279311ceebc62bc8d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=030281a55b4552c76b93cedf957637d6ba104b01

Same as before, many panics

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 95c59bb728d50ed195e97397ebbbb2a91ca20ca8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2d5ed238d15c8cd061d5202104a132fa3e49c12

Same as before

WR @ 1ca448a162ef2aee8f6ed232200d382719fb405c

https://treeherder.mozilla.org/#/jobs?repo=try&revision=059d4f6b01e13547633496cc649c76b0f8c6e282

Even more bustage, "Unable to open shader file", so probably from servo/webrender#2891

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Did a try from just before servo/webrender#2891 landed: WR @ fc91e8680816b27987afd0de543cacd052dd9d10

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb136e39ff30998ee001d6e390efe9fe674a3546

Looking good so far (i.e. still has the panics from before, but not the shader errors). So the shader errors are definitely from servo/webrender#2891

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 2cb682553816200bb74ce75d3851753bc122f488

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3b87524864a797f75a5b4ce78532a82affc248e

Shader errors were reverted, back to the panics we had before.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fdc7f00aba1
Update webrender to commit 9f21ee5dba0694818a1e2e46d95734ede281447c
https://hg.mozilla.org/integration/mozilla-inbound/rev/7041b2f0aef8
Update Cargo lockfiles, re-vendor rust dependencies

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5fdc7f00aba1
https://hg.mozilla.org/mozilla-central/rev/7041b2f0aef8