Closed Bug 1495372 Opened 6 years ago Closed 6 years ago

Perma [tier2] Wm Fatal: manifest path /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_tests/web-platform/meta does not exist

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: ebalazs_, Assigned: jgraham)

Details

Attachments

(1 file)

Bug 1495372 - Unify wpt manifest download and update
46 bytes, text/x-phabricator-request
Details | Review 
This started after https://bugzilla.mozilla.org/show_bug.cgi?id=1495007 landed:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending,running,success,testfailed,busted,exception,usercancel,runnable&searchStr=linux,x64,opt,source-test-wpt-manifest-upload,(wm)&selectedJob=202530458

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=202530458&repo=autoland

Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-10-01T06:58:39.972Z]  0:01.14 WARNING No generated manifest found
[task 2018-10-01T06:58:39.972Z]  0:01.14 INFO Could not download manifests.
[task 2018-10-01T06:58:39.972Z]  0:01.14 INFO Generating from scratch instead.
[task 2018-10-01T06:58:39.974Z]  0:01.15 INFO Updating manifests
[task 2018-10-01T06:58:39.976Z] Fatal: manifest path /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_tests/web-platform/meta does not exist
[taskcluster 2018-10-01 06:58:40.649Z] === Task Finished ===
[taskcluster 2018-10-01 06:58:40.733Z] Artifact "public/manifests.tar.gz" not found at "/builds/worker/checkouts/gecko/manifests.tar.gz"
[taskcluster 2018-10-01 06:58:41.379Z] Unsuccessful task run with exit code: 1 completed in 288.093 seconds

jgraham: Can you take a look into this? Thanks!
Flags: needinfo?(james)
The previous code split a lot of logic between the update and download
parts, and exposed two different mach commands. In order to simplify
things it's better to have a single entry point for manifest download
and update, and ensure that's called consistently.
ato: Hi, This is a perma failure, your review would be helpful? Thank you!
Flags: needinfo?(ato)
Flags: needinfo?(ato)
jgraham: You updated the patch, did you not land this?
Sorry, I misinterpreted the needinfo from ebalazs_ to mean I needed
to look at a backout of jgraham’s patch.  I must have thought this
because I reviewed some code in a related area in WPT last week.
Sorry about this.

I’ve now reviewed the patch and I can’t spot any major obstacles
for why we shouldn’t be able to land this.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/8660ad891a23
Unify wpt manifest download and update r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13347 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/8660ad891a23
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Backed out for causing win2012 bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=busted&searchStr=wind,2012&selectedJob=203201456

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=203198261&repo=autoland&lineNumber=42733

Backout link: https://hg.mozilla.org/mozilla-central/rev/65fc22a1627b7de54303275dbe2422a61080865c

22:27:35     INFO -  package-tests>   File "z:\build\build\src\testing\web-platform\manifestdownload.py", line 142, in download_manifest
22:27:35     INFO -  package-tests>
22:27:35     INFO -  package-tests>     logger.debug("Unpacking %s to %s" % (member.name, paths["manifest_path"]))
22:27:35     INFO -  package-tests>
22:27:35     INFO -  package-tests> UnboundLocalError: local variable 'member' referenced before assignment
22:27:35     INFO -  package-tests>
22:27:35     INFO -  package-tests> z:/build/build/src/testing/testsuite-targets.mk:158: recipe for target 'download-wpt-manifest' failed
22:27:35     INFO -  package-tests> mozmake.EXE[2]: *** [download-wpt-manifest] Error 1
22:27:35     INFO -  package-tests> mozmake.EXE[2]: Leaving directory 'z:/build/build/src/obj-firefox'
22:27:35     INFO -  package-tests> mozmake.EXE[2]: *** Waiting for unfinished jobs....
22:28:05     INFO -  package> mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer'
Status: RESOLVED → REOPENED
status-firefox64: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13354 for changes under testing/web-platform/tests
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2adff75db60c
Unify wpt manifest download and update, r=ato
Flags: needinfo?(james)
https://hg.mozilla.org/mozilla-central/rev/2adff75db60c
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee: nobody → james
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b67ae2b52ae
[wpt PR 13354] - [Gecko Bug 1495372] Backed out changeset 8660ad891a23 (bug 1495372) for causing win2012 bustages. a=backout, a=testonly
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: