46 bytes, text/x-phabricator-request
|Details | Review|
Bug 1477102 added icons for the subset of card networks that are supported by Web Payments (Basic Card). We can use these to add a more informative icon in the formautofill card management UI in preferences.
Created attachment 9013421 [details] Bug 1495530 - Use card icons in form autofill card preferences screen. r?MattN
There's not a good way to test the CSS gets applied as the backgroundImage is on a pseudo element. So I settled for just verifying the .brand class is toggled on the <select> as appropriate.
Comment on attachment 9013421 [details] Bug 1495530 - Use card icons in form autofill card preferences screen. r?MattN Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9013421 - Flags: review+
4 months ago
Status: NEW → ASSIGNED
Try run with the changes requested, on the Trunk as early Beta/uplift patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1fdbf0ea631d283dbb37eb6c668ce6f7ff94ba1
Try looks good :)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/32cde67dd330 Use card icons in form autofill card preferences screen. r=MattN
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
You need to log in before you can comment on or make changes to this bug.