Closed Bug 1495530 Opened 2 years ago Closed 2 years ago

Use card network icons in manage credit cards list

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox64 --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [webpayments])

Attachments

(1 file)

Bug 1477102 added icons for the subset of card networks that are supported by Web Payments (Basic Card). We can use these to add a more informative icon in the formautofill card management UI in preferences.
There's not a good way to test the CSS gets applied as the backgroundImage is on a pseudo element. So I settled for just verifying the .brand class is toggled on the <select> as appropriate.
Assignee: nobody → sfoster
Priority: -- → P1
Comment on attachment 9013421 [details]
Bug 1495530 - Use card icons in form autofill card preferences screen. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9013421 - Flags: review+
Status: NEW → ASSIGNED
Whiteboard: [webpayments]
Try run with the changes requested, on the Trunk as early Beta/uplift patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1fdbf0ea631d283dbb37eb6c668ce6f7ff94ba1
Try looks good :)
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32cde67dd330
Use card icons in form autofill card preferences screen. r=MattN
https://hg.mozilla.org/mozilla-central/rev/32cde67dd330
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.