Closed
Bug 1495530
Opened 6 years ago
Closed 6 years ago
Use card network icons in manage credit cards list
Categories
(Firefox :: Settings UI, enhancement, P1)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | verified |
People
(Reporter: sfoster, Assigned: sfoster)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Bug 1477102 added icons for the subset of card networks that are supported by Web Payments (Basic Card). We can use these to add a more informative icon in the formautofill card management UI in preferences.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
There's not a good way to test the CSS gets applied as the backgroundImage is on a pseudo element. So I settled for just verifying the .brand class is toggled on the <select> as appropriate.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sfoster
Priority: -- → P1
Comment 3•6 years ago
|
||
Comment on attachment 9013421 [details] Bug 1495530 - Use card icons in form autofill card preferences screen. r?MattN Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9013421 -
Flags: review+
Updated•6 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [webpayments]
Assignee | ||
Comment 4•6 years ago
|
||
Try run with the changes requested, on the Trunk as early Beta/uplift patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1fdbf0ea631d283dbb37eb6c668ce6f7ff94ba1
Comment 5•6 years ago
|
||
Try looks good :)
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32cde67dd330 Use card icons in form autofill card preferences screen. r=MattN
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32cde67dd330
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Flags: qe-verify?
Updated•6 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Comment 8•6 years ago
|
||
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•