1477102 - Show card network logos on the card add/edit screens

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

The details are still being sorted out but we will want card network logos on the payment summary and/or basic card add/edit screens.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Bug 1429181 uses a placeholder treatment for the "merchant accepts: " logos on both the summary and add/edit card pages. This bug should replace those with real image assets. 

Eric, I'm flagging you just so you know where to let me know when you have these ready.

Comment 2

[Matthew N. [:MattN]]

Please provide all the logos in bug 1392520 to keep them all in one place.

Comment 3

[Matthew N. [:MattN]]

Are we supposed to hide the "Merchant accepts" section from the add form when the merchant doesn't provide a list (and therefore all are accepted)?

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)
> Are we supposed to hide the "Merchant accepts" section from the add form
> when the merchant doesn't provide a list (and therefore all are accepted)?

Yes that whole line should be hidden if there's no supportedNetworks in the payment methods we get. We (now) have tests that should confirm this is the case. Can you file a bug if you see otherwise?

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] from comment #4)
> (In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from
> comment #3)
> > Are we supposed to hide the "Merchant accepts" section from the add form
> > when the merchant doesn't provide a list (and therefore all are accepted)?

I've implemented hiding this line for the summary page, but I think not for the add/edit card page. Maybe that was the question for UX?

Comment 6

[Matthew N. [:MattN]]

Right, we only implemented for the summary page, so that was a question for UX and this bug can already handle addressing the answer.

Comment 7

[Eric Pang [:epang] UX]

If the merchant doesn't provide a list then we should hide it for the summary, edit and add new payment method screens. thanks!

Comment 8

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r?MattN

Comment 9

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r?MattN

Depends on D7025

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 9012416 [details]
Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 9012417 [details]
Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce23e4daf8d
Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
https://hg.mozilla.org/integration/autoland/rev/04f74c53d537
Add third-party payment card logos, enable their use in official, branded builds. r=MattN

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6ce23e4daf8d
https://hg.mozilla.org/mozilla-central/rev/04f74c53d537

Comment 14

[Hani Yacoub, Desktop QA]

Card network logo that Merchants accepts are displayed in summary page, edit and add payments method. Tested this part on this test page "https://paymentrequest.show/demo/".

On this test page "https://rsolomakhin.github.io/pr/single/" I verified that the accepted cards aren't displayed if the merchant didn't have a preference (summary, edit and add new payment method screens).

But in case I added a new card (Visa for example), and Visa isn't supported. I added Visa card number but I select form "Card Type" drop down a supported network(Master for example).
Is it OK in this case to be validated as a correct card? Is this handled in another bug and the first two things verified above is sufficient to mark this bug as verified?

Comment 15

[Sam Foster [:sfoster] (he/him)]

(In reply to Hani Yacoub from comment #14)
> But in case I added a new card (Visa for example), and Visa isn't supported.
> I added Visa card number but I select form "Card Type" drop down a supported
> network(Master for example).
> Is it OK in this case to be validated as a correct card? Is this handled in
> another bug and the first two things verified above is sufficient to mark
> this bug as verified?

Yes and yes, that is bug 1494564.

Comment 16

[Timea Cernea [:tbabos][inactive]]

Hi Sam!

Further testing revealed that the "Merchant accepts:" string is missing on Ubuntu 16.04. Only the logo images are displayed. Should I submit a new issue for this or can it be handled in an existing one?

Comment 17

[Sam Foster [:sfoster] (he/him)]

(In reply to Timea Babos from comment #16)
> Hi Sam!
> 
> Further testing revealed that the "Merchant accepts:" string is missing on
> Ubuntu 16.04. Only the logo images are displayed. Should I submit a new
> issue for this or can it be handled in an existing one?

I'm not able to reproduce that. Can you file a new bug with a screenshot, the test page you were using and any details you can add to help reproduce?

Comment 18

[Timea Cernea [:tbabos][inactive]]

Hey Sam,

I tried to reproduce it once more but didn't manage to. :(
Will file a new bug if it occurs again and I can get reliable steps. 

Will close this issue as Verified - Fixed on all OSes.