1495614 - Search engine keyword/alias is highlighted inside URLs

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

(In reply to Bruce from bug 1491724 comment #5)
> Testing on 64.0a1 (2018-09-30) in WIndows 10, I noticed a small issue:
> 
> STR:
> 1. Give a keyword of `w` to the 'Wikipedia (en)' search engine
> 2. Type `w test` and press Enter.
> 3. Click on the url bar.
> 
> AR: `w` is briefly highlighted before the whole url is selected.

See bug 1491724 attachment 9013212 [details]

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1495614 - Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result

Comment 2

[Drew Willcoxon :adw]

This patch also fixes bug 1497515

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8411d22c2440
Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result r=mak

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8411d22c2440

Comment 5

[Sajedul Islam]

I have reproduced this bug with 64.0a1 (2018-10-01) (64-bit) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with beta 64.0b8 !

Build   ID    20181108141956
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

[testday20180914]

Comment 6

[Anca Soncutean, Desktop QA]

Thank you Sajedul! 

Based on comment 5 I will mark this issue as verified fixed.