Closed Bug 1495614 Opened 3 years ago Closed 3 years ago
Search engine keyword/alias is highlighted inside URLs
Bug 1495614 - Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result
46 bytes, text/x-phabricator-request
|Details | Review|
(In reply to Bruce from bug 1491724 comment #5) > Testing on 64.0a1 (2018-09-30) in WIndows 10, I noticed a small issue: > > STR: > 1. Give a keyword of `w` to the 'Wikipedia (en)' search engine > 2. Type `w test` and press Enter. > 3. Click on the url bar. > > AR: `w` is briefly highlighted before the whole url is selected. See bug 1491724 attachment 9013212 [details]
This patch also fixes bug 1497515
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8411d22c2440 Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result r=mak
QA Whiteboard: [good first verify]
I have reproduced this bug with 64.0a1 (2018-10-01) (64-bit) on Windows 10 , 64 Bit ! This bug's fix is Verified with beta 64.0b8 ! Build ID 20181108141956 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 [testday20180914]
Thank you Sajedul! Based on comment 5 I will mark this issue as verified fixed.
You need to log in before you can comment on or make changes to this bug.