Closed Bug 1495657 Opened 6 years ago Closed 5 years ago

Remove DebuggerClient.addListener calls related to workerListChanged once all related client are converted to fronts

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ochameau, Unassigned)

References

(Blocks 2 open bugs)

Details

Bug 1485660 is introducing a temporary code in order to support either old fashion client, emitting events on DebuggerClient or fronts, emitting events on the front itself. We should remove that and only listen on fronts once all the related clients are converted to fronts. i.e. bug 1485660, bug 1485661, bug 1494632. This only impact two files: * devtools/client/debugger/debugger-controller.js * devtools/client/debugger/new/src/client/firefox/events.js And will concists in doing: - // `_tabClient` an be BrowsingContextTargetFront (protocol.js front) or WorkerClient - // (old fashion client) - if (typeof(this._tabClient.on) == "function") { - this._tabClient.on("workerListChanged", this._onWorkerListChanged); - } else { - this._tabClient.addListener("workerListChanged", this._onWorkerListChanged); - } + this._tabClient.on("workerListChanged", this._onWorkerListChanged);
Severity: normal → enhancement
Priority: -- → P2
Whiteboard: dt-fission
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Priority: P2 → P1
Resolution: FIXED → WORKSFORME
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.