Closed Bug 1494632 Opened Last year Closed 11 months ago

Convert WorkerClient to protocol.js front

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(1 file)

WorkerClient is the client class to connect to the worker target actor.
We should convert that client class to a protocol.js front.

It introduced some complexity in the patch to convert TabClient to a front.
Both these classes end up being set on Target.activeTab attribute.

It introduces discrepancy in how to listen for events.
For protocol.js and TabClient converted to a front, you have to do:
  target.activeTab.on("frameUpdate", (packet) => {..});
while for WorkerClient you have to do:
  client.addListener("frameUpdate", (type, packet) => {..});

Bug 1485660 is going to introduce these two ways of listening for target actor's events, but once this bug is completed we can stick to one, the protocol.js one.
Assignee: nobody → poirot.alex
Blocks: 1495657
MozReview-Commit-ID: BbtEReeG4v9

Depends on D7462
Severity: normal → enhancement
Priority: -- → P2
Attachment #9013669 - Attachment description: Bug 1494632 - Convert WorkerClient to protocol.js front → Bug 1494632 - Convert WorkerClient to protocol.js front.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89308a0efe91
Convert WorkerClient to protocol.js front. r=jdescottes
Blocks: 1499333
https://hg.mozilla.org/mozilla-central/rev/89308a0efe91
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.