1494632 - Convert WorkerClient to protocol.js front

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

WorkerClient is the client class to connect to the worker target actor.
We should convert that client class to a protocol.js front.

It introduced some complexity in the patch to convert TabClient to a front.
Both these classes end up being set on Target.activeTab attribute.

It introduces discrepancy in how to listen for events.
For protocol.js and TabClient converted to a front, you have to do:
  target.activeTab.on("frameUpdate", (packet) => {..});
while for WorkerClient you have to do:
  client.addListener("frameUpdate", (type, packet) => {..});

Bug 1485660 is going to introduce these two ways of listening for target actor's events, but once this bug is completed we can stick to one, the protocol.js one.

Comment 1

[Alexandre Poirot [:ochameau]]

Almost green try:
  https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=202876952&revision=90a93202cf33d65a145f217bfec4831bf6d00dd5

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1494632 - Convert WorkerClient to protocol.js front.

MozReview-Commit-ID: BbtEReeG4v9

Depends on D7462

Comment 3

[Alexandre Poirot [:ochameau]]

One last try run before landing:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bfd33cce5af289df3b75906a933b8d98b2bc5f8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89308a0efe91
Convert WorkerClient to protocol.js front. r=jdescottes

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/89308a0efe91