1495665 - No way to open new profiler panel for remote debugging after landing bug 1459720

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Makoto Kato [:m_kato]]

After landing bug 1459720, profiler panel is hidden for remote target in WebIDE and, If opening devtool for local, this panel is shown.

But when using upcoming about:debugging, there is no way to open/show the profiler panel since this panel is still hidden for remote target.

So we should add new menu or anyway to open/show profiler panel for remote target.

Comment 1

[Brian Birtles (:birtles)]

Marking this as blocking M1 since it sounds like something we want to work when we switch about:debugging on.

Comment 2

[Julian Descottes [:jdescottes]]

I think we need to discuss about this one. m1 is about basic USB tab debugging, and this bug is about the new performance panel. Also this needs UX work, as the new "panel" apparently cannot be used correctly if the toolbox started. 

> when we switch about:debugging on

This needs to be clarified as well. The new about:debugging aims to replace the old about:debugging, webIDE and the connect page.
With the current milestones proposed, we have:
- m3: parity with old about:debugging
- m5: parity with WebIDE
- m6: parity with Connect page

The feature discussed here is a WebIDE feature, so in my opinion as long as we tolerate WebIDE gaps, this bug is not a blocker.

Comment 3

[Julian Descottes [:jdescottes]]

Moving back to triage, we should probably tackle performance panel gap earlier, because developers who want to profile Gecko View applications today are forced to use WebIDE at the moment.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: profiler_collapsible.gif

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: profiler_new_tab.gif

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: profiler_modal.gif

Comment 7

[Julian Descottes [:jdescottes]]

Two try pushes with the code for the protos:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e431c5955cd7bf78b100a856b5f7bbd0e85c45bb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fa1d655b39013ac94063e42d64a203ab2f850db

Comment 8

[Julian Descottes [:jdescottes]]

Harald, do you have a preference between the 3 prototypes we attached here?

Personally as a temporary solution, my preferred option would be the modal version.
modal version screencast

Close second is the "about:profiling" tab. Technically speaking I like the fact that this has almost 0 impact on the code of about:debugging. But it's yet another tab opened for the user, and I feel like about:debugging is already opening too many tabs.
new tab version screencast

My least preferred option would be the "collapsible" category. Too inconsistent.
collapsible version screencast

Comment 9

[:Harald Kirschner :digitarald]

Personally as a temporary solution, my preferred option would be the modal version.

Good enough as a solution while we figure out the details of migrating the Profiler fully into Firefox. While we don't have similar overlays in devtools; it is used in other about pages and is part of photon (needs the header with title and close button): https://design.firefox.com/photon/patterns/overlay.html

Close second is the "about:profiling" tab. Technically speaking I like the fact that this has almost 0 impact on the code of about:debugging. But it's yet another tab opened for the user, and I feel like about:debugging is already opening too many tabs.

I also like that this is in line with other interactions in about:debugging; but having its own tab feels a bit heavy (especially as it opens more tabs for collected profiles).

+1 on the modal as preferred solution.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1495665 - Add profile runtime button for remote runtime pages;r=ladybenko,ola

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1495665 - Add performance panel as modal dialog in about:debugging;r=ladybenko,ola

Comment 12

[Julian Descottes [:jdescottes]]

Attachment: Bug 1495665 - Add test for profiler dialog in aboutdebugging;r=ladybenko,ola

Depends on D18698

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b7949b3d6d3
Add profile runtime button for remote runtime pages;r=ladybenko,Ola
https://hg.mozilla.org/integration/autoland/rev/b096b883636d
Add performance panel as modal dialog in about:debugging;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/106bb3f48beb
Add test for profiler dialog in aboutdebugging;r=ladybenko

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0b7949b3d6d3
https://hg.mozilla.org/mozilla-central/rev/b096b883636d
https://hg.mozilla.org/mozilla-central/rev/106bb3f48beb

Comment 15

[Liviu Seplecan]

Verified on Nightly 68.0a1, Beta 67.0b6 -on several machines: Windows 10, MAC OS X, Ubuntu 16.0