1495901 - SES type checking error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

We seem to be expecting different input than we're receiving.

Reference {"bounce" => {"bounceSubType" => "General","bounceType" => "...} did not pass type constraint "Dict[bounce=>Dict[bounceSubType=>Str,bounceType=>Str,bouncedRecipients=>ArrayRef[Dict[action=>Str,diagnosticCode=>Str,emailAddress=>Str,slurpy Any]],reportingMTA=>Str,slurpy Any],slurpy Any]" (in $_[1]) at /app/Bugzilla/Quantum/SES.pm line 108
    Reference {"bounce" => {"bounceSubType" => "General","bounceType" => "...} did not pass type constraint "Dict[bounce=>Dict[bounceSubType=>Str,bounceType=>Str,bouncedRecipients=>ArrayRef[Dict[action=>Str,diagnosticCode=>Str,emailAddress=>Str,slurpy Any]],reportingMTA=>Str,slurpy Any],slurpy Any]" (in $_[1])
    "Dict[bounce=>Dict[bounceSubType=>Str,bounceType=>Str,bouncedRecipients=>ArrayRef[Dict[action=>Str,diagnosticCode=>Str,emailAddress=>Str,slurpy Any]],reportingMTA=>Str,slurpy Any],slurpy Any]" constrains value at key "bounce" of hash with "Dict[bounceSubType=>Str,bounceType=>Str,bouncedRec

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: GitHub Pull Request

Comment 2

[Dylan Hardison [:dylan] (he/him)]

The problem is that some fields (like diagnostic code) are actually optional.
I fixed that, and also made the type checking more standard.

Comment 3

[David Lawrence [:dkl]]

Merged to master.