1496189 - Password quality meter show always undetermined

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Richard Marti (:Paenglab)]

Attachment: passwordQuality.png

In FX preferences "Change Master Password" dialog the password quality meter shows always undetermined and not the strength progress. Also does the green bar not use the full height.

The same happens to Thunderbird's account quota meter.

Comment 1

[alexander :surkov (:asurkov)]

(In reply to Richard Marti (:Paenglab) from comment #0)
> Created attachment 9014124 [details]
> passwordQuality.png
> 
> In FX preferences "Change Master Password" dialog the password quality meter
> shows always undetermined and not the strength progress. Also does the green
> bar not use the full height.
> 
> The same happens to Thunderbird's account quota meter.

which os x this is?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov (:asurkov) from comment #1)
> (In reply to Richard Marti (:Paenglab) from comment #0)
> > Created attachment 9014124 [details]
> > passwordQuality.png
> > 
> > In FX preferences "Change Master Password" dialog the password quality meter
> > shows always undetermined and not the strength progress. Also does the green
> > bar not use the full height.
> > 
> > The same happens to Thunderbird's account quota meter.
> 
> which os x this is?

no 'x' for sure :)

Comment 3

[Richard Marti (:Paenglab)]

Windows 10.

Comment 4

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Functionality regression that needs fixing for Fx64 so we don't ship it.

:surkov, are you able to pick this up? :-)

Comment 5

[Richard Marti (:Paenglab)]

On Linux no progress is shown in the master password dialog. Only the empty progressmeter container.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to :Gijs (he/him) from comment #4)
> [Tracking Requested - why for this release]:
> Functionality regression that needs fixing for Fx64 so we don't ship it.
> 
> :surkov, are you able to pick this up? :-)

I guess I should. The trickiest part is I don't have ready-to-work linux/win machines at hands to debug the thing.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9015188 [details] [diff] [review]
patch

This works on Windows and Linux.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to Richard Marti (:Paenglab) from comment #8)
> Comment on attachment 9015188 [details] [diff] [review]
> patch
> 
> This works on Windows and Linux.

Thank you so much for checking it!

Comment 10

[:Paolo Amadini]

Comment on attachment 9015188 [details] [diff] [review]
patch

Ah, whoops! Didn't notice this was inverted when reviewing the patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccbd30a9a23a
Password quality meter show always undetermined, r=paolo

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ccbd30a9a23a

Comment 14

[Mohammad Maruf Rahman]

I Have reproduced this bug with Nightly 64.0a1 (2018-10-03) on Windows 7, 64 Bit!
This bug's fix is verified with latest Beta!

Build ID 	20181108141956
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0