1496241 - Activity Stream doesn't honor default preference set via Autoconfig (and policy)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

We've had request from folks to set some activity stream prefs via policy and autoconfig:

browser.newtabpage.activity-stream.default.sites
browser.newtabpage.activity-stream.feeds.section.highlights
browser.newtabpage.activity-stream.feeds.snippets
browser.newtabpage.activity-stream.migrationExpired
browser.newtabpage.activity-stream.showSearch
browser.newtabpage.activity-stream.topSitesRows
browser.onboarding.enabled

What I've discovered is that if you set many of these prefs as default prefs (which is typical in autoconfig and policy), activity stream doesn't read the default values (it only reads user values).

The problem seems to be that activity stream sets the default values without checking to see if they exist as default values already.

Comment 1

[Tim Spurway [:tspurway]]

:mkaply, is this for ESR configurations?

Comment 2

[Mike Kaply [:mkaply]]

> :mkaply, is this for ESR configurations?

Yes. It's should we can add policies to configure the new tab/activity stream for enterprises.

Comment 3

[Ed Lee :Mardak]

Looks like we can follow the same pattern used in bug 1245277. Although some quick testing shows that if the user has set a pref, the PREF_INVALID check from the default branch will still get the type of the user set value. So potentially we could end up in a situation where there's no default…

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4531

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b79d9f4c37eb5f396dd6f18fd1311d0550998aa0
Fix Bug 1496241 - Activity Stream doesn't honor default preference set via Autoconfig (and policy) (#4531)

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/49d47a692ca4