1496292 - Some XML coverage might be missing in raw JSVM data

Status: NEW

(Testing :: Code Coverage, defect, P3)

Description

[Greg Mierzwinski [:sparky]]

Looking at the attachment in the description of bug 1496285, we are missing the following coverage in JSVM data:

chrome://global/content/bindings/general.xml: [16, 17, 29, 30]
chrome://global/content/bindings/text.xml: [20, 21]

There is also coverage missing for files that are covered in both, for instance (I am not 100% sure if these are the same files though):

JSVM:
browser/components/customizableui/content/toolbar.xml: [13, 15, 16, 17, 21, 22, 23, 24, 26, 27, 28, 34, 35, 36, 37, 69, 71, 72, 74, 75, 76, 78, 79, 81, 83, 85, 175, 178, 180, 230, 247, 251, 272, 273, 274, 275, 276, 277, 278]

JSDCOV:
chrome://browser/content/customizableui/toolbar.xml: [69, 71, 72, 85, 74, 75, 76, 78, 79, 81, 83]

Comment 1

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

the toolbar.xml file is the same, it is packed up in a jar.mn file:
https://searchfox.org/mozilla-central/source/browser/components/customizableui/content/jar.mn#7

Comment 2

[Greg Mierzwinski [:sparky]]

Perfect, and JSVM contains all the JSDCOV coverage, so this would be a JSDCOV bug instead of one specific to JSVM. That said, the other two files are still missing.

Comment 3

[Greg Mierzwinski [:sparky]]

The text.xml file is hit intermittently in JSVM, here's some coverage of it: https://gist.github.com/gmierz/2201c02d661fa7cd99c7f17fce4aa779

You can find " 20," in there but not 21, meaning that it could be a bug in either jsdcov or jsvm. It's more likely to be jsdcov though as it's missing a large amount of coverage already. I would say that this file is fine, if not better in jsvm, even if it's intermittent.

Here's the file for it (since the latest revisions changed it): https://hg.mozilla.org/mozilla-central/annotate/5c2a8331f82c/toolkit/content/widgets/text.xml

I haven't found 'general.xml' in JSVM yet though, so it may be very intermittent, because of that I am looking through a few more chunks.

Comment 4

[Marco Castelluccio [:marco]]

We have to check to see if this is still happening.