1496324 - Fix TransactionId handling in WebRenderLayerManager::EndEmptyTransaction()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

The EndEmptyTransaction() does not get TransactionId by calling nsRefreshDriver::GetTransactionId() when transaction is not necessary. But it seems not good.

In this case, it seems necessary to call the GetTransactionId() and then need to call nsRefreshDriver::RevokeTransactionId() to trigger next paint.

Comment 1

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203304764&revision=43f3893f7aca0c5671f99cc73970f0ec45ab636d

Intermittent failure of Bug 1489327 seemed to be addressed.

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203304764&revision=43f3893f7aca0c5671f99cc73970f0ec45ab636d
> 
> Intermittent failure of Bug 1489327 seemed to be addressed.

Though, failure of Bug 1490117 still exists.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Revoke TransactionId when transaction is not forwarded

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Revoke TransactionId when transaction is not forwarded

Comment 5

[Sotaro Ikeda [:sotaro]]

ClientLayerManager also revoke TransactionId when transaction is not forwarded.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientLayerManager.cpp#749

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b41309fe5d6
Revoke TransactionId when transaction is not forwarded r=mattwoodrow

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1b41309fe5d6