Fix TransactionId handling in WebRenderLayerManager::EndEmptyTransaction()

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 months ago
The EndEmptyTransaction() does not get TransactionId by calling nsRefreshDriver::GetTransactionId() when transaction is not necessary. But it seems not good.

In this case, it seems necessary to call the GetTransactionId() and then need to call nsRefreshDriver::RevokeTransactionId() to trigger next paint.
(Assignee)

Updated

8 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

8 months ago
Blocks: 1459233
(Assignee)

Comment 2

8 months ago
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203304764&revision=43f3893f7aca0c5671f99cc73970f0ec45ab636d
> 
> Intermittent failure of Bug 1489327 seemed to be addressed.

Though, failure of Bug 1490117 still exists.
Comment hidden (obsolete)
(Assignee)

Comment 5

8 months ago
ClientLayerManager also revoke TransactionId when transaction is not forwarded.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientLayerManager.cpp#749
(Assignee)

Updated

8 months ago
Attachment #9014287 - Flags: review?(matt.woodrow)
Attachment #9014287 - Flags: review?(matt.woodrow) → review+

Comment 6

8 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b41309fe5d6
Revoke TransactionId when transaction is not forwarded r=mattwoodrow

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b41309fe5d6
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.