1496353 - Port bug 1461798 - tooltip binding removed - TEST-UNEXPECTED-FAIL | [snip]mozmill\folder-display\test-tooltip-multimessage.js | test-tooltip-multimessage.js::test_tooltips

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

When run locally I get:

SUMMARY-UNEXPECTED-FAIL | c:\mozilla-source\comm-central\comm\mail\test\mozmill\folder-display\test-tooltip-multimessage.js | test-tooltip-multimessage.js::test_tooltips
  EXCEPTION: tooltip.fillInPageTooltip is not a function
    at: test-tooltip-multimessage.js line 44
       test_tooltips test-tooltip-multimessage.js:44 3

M-C last good: 07aa30516b54bf2644120c51a73cac2f9c
M-C first bad: 8b1f1ebed0f0d6c8abc7e201d70d999f92
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=07aa30516b54bf2644120c51a73cac2f9c&tochange=8b1f1ebed0f0d6c8abc7e201d70d999f92

This comes from
Bug 1461798 - Migrate <tooltip> to a C++ implementation. r=smaug
which removed that binding :-(
https://hg.mozilla.org/mozilla-central/rev/2d5a7c965683#l18.48

Looks like a case for Arshad and Magnus.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1496353-disable-test.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e08d005eaad4
temporarily disable MozMill test test-tooltip-multimessage.js. rs=bustage-fix DONTBUILD

Comment 3

[Arshad Khan [:arshad]]

Hey, I am not sure what to do. TB has its tooltip which is extending FX tooltip and folderSummary-popup is there which extends TB's tooltip..

Comment 4

[Magnus Melin [:mkmelin]]

It's a bit hard to say, but perhaps you can migrate folderSummary-popup to a CE, then use the bits you need from https://phabricator.services.mozilla.com/D3056 (CE version of <tooltip> from bug 1461798). 

Emilio, do you see any problems with this, off hand? I don't understand the issues discussed in bug 1461798. We're trying to figure out how to deal with the folderSummary-popup binding https://searchfox.org/comm-central/source/mail/base/content/mailWidgets.xml#2303

It's only used once https://searchfox.org/comm-central/source/mail/base/content/messenger.xul#303 so we don't need cater for more use cases than that.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

TBH I'm not that familiar with what ended up happening in that bug, but the issues with using a custom-element were that there are anonymous <tooltip> elements created with C++, so those issues should not apply to this binding.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1496353_tooltip_test.patch

I don't think this test is useful to keep around. We're testing toolkit functionality, and they already test it quite thoroughly in mozilla/toolkit/components/tooltiptext/tests/.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9022558 [details] [diff] [review]
bug1496353_tooltip_test.patch

OK. I prefer to keep landed patches as attachments, so you can see what's gone on.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/25adff603af0
remove multimessage tooltip test. r=jorgk