46 bytes, text/x-phabricator-request
|Details | Review|
We currently do nothing if HttpChannel::OnStartRequest returns failure , which is not correct. We can try to adapt the logic in HttpChannelChild  here. Moreover, we should also consider if we need ChannelEventQueue in HttpTransactionParent.  https://hg.mozilla.org/projects/larch/file/tip/netwerk/protocol/http/HttpTransactionParent.cpp#l205  https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/netwerk/protocol/http/HttpChannelChild.cpp#771-775
Assignee: nobody → kershaw
Priority: -- → P2
I think when  fails we should Cancel(rv) the pipe (which is |this| actually, the HttpTransactionParent object), rv = chan->OnStartRequest(this, nullptr);. The contract is that when OnStart fails, we must not call OnData and propagate the error to OnStop
QA Contact: jduell.mcbugs
When OnStart fails, we must not call OnData and propagate the error to OnStop.
Looks like this can land now, unless there is some dependency not listed in this bug.
(In reply to Honza Bambas (:mayhemer) from comment #3) > Looks like this can land now, unless there is some dependency not listed in > this bug. Already landed.
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.