1496464 - Handle the result of OnStartRequest correctly in HttpTransactionParent::RecvOnStartRequest

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Kershaw Chang [:kershaw]]

We currently do nothing if HttpChannel::OnStartRequest returns failure [1], which is not correct.
We can try to adapt the logic in HttpChannelChild [2] here.

Moreover, we should also consider if we need ChannelEventQueue in HttpTransactionParent.


[1] https://hg.mozilla.org/projects/larch/file/tip/netwerk/protocol/http/HttpTransactionParent.cpp#l205
[2] https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/netwerk/protocol/http/HttpChannelChild.cpp#771-775

Comment 1

[Honza Bambas (:mayhemer)]

I think when [1] fails we should Cancel(rv) the pipe (which is |this| actually, the HttpTransactionParent object), rv = chan->OnStartRequest(this, nullptr);.  

The contract is that when OnStart fails, we must not call OnData and propagate the error to OnStop

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1496464 - Cancel the transaction if OnStartRequest fails

When OnStart fails, we must not call OnData and propagate
the error to OnStop.

Comment 3

[Honza Bambas (:mayhemer)]

Looks like this can land now, unless there is some dependency not listed in this bug.

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Honza Bambas (:mayhemer) from comment #3)
> Looks like this can land now, unless there is some dependency not listed in
> this bug.

Already landed.

Comment 5

[Kershaw Chang [:kershaw]]

https://hg.mozilla.org/projects/larch/rev/9f014528a74861685601f3d52522c7d14cc907ef