1496491 - Close tab button doesn't work after tab bar animates

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P2)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Close button selection after tab bar scroll animation

Steps to reproduce:
1. Create enough tabs (or make the window narrow enough) that early tabs scroll off the left
2. Click the rightmost tab's close button, another tab will scroll in under the cursor and its close button will appear selected with the mouseover
3. Click the close button

Expected result:
Tab closes

Observed result:
Close button deselects, nothing else happens. It appears to work as just a click on the titlebar. Moving the mouse off of the close button and back causes the highlight to flicker but the button still doesn't work. Selecting another tab seems to fix it.

Seen on Windows 10. It only seems to happen when the tab bar scrolls following a tab close.

mozregression gave:

Last good revision: ef315578d7484d702ed83cf4f9d3d3af20515ad7
First bad revision: 19165a49129512561ee268e671c9e389b566b489
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef315578d7484d702ed83cf4f9d3d3af20515ad7&tochange=19165a49129512561ee268e671c9e389b566b489

which points at bug 1491400.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Adam Gashlin [:agashlin] from comment #0)
> mozregression gave:
> 
> Last good revision: ef315578d7484d702ed83cf4f9d3d3af20515ad7
> First bad revision: 19165a49129512561ee268e671c9e389b566b489
> Pushlog:
> https://hg.mozilla.org/integration/autoland/
> pushloghtml?fromchange=ef315578d7484d702ed83cf4f9d3d3af20515ad7&tochange=1916
> 5a49129512561ee268e671c9e389b566b489
> 
> which points at bug 1491400.

This doesn't seem to make any sense and is likely wrong.

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=abd419a57735832ac235c23716225c2b38abd759&tochange=260007b95d6791a665a7ce2ba45664182b119609

Regressed by:
260007b95d67	Miko Mynttinen — Bug 1494124 - Allow only one rect per frame in WeakFrameRegion r=mattwoodrow

@:miko,
Your patch causes the ux regression, can you please look into this?

Comment 4

[Miko Mynttinen]

Attachment: Bug 1496491 - Disable parent process RDL

Comment 5

[Miko Mynttinen]

I have not looked into this in more detail yet, but this bug is likely caused by a Windows specific frame invalidation issue during tab animation and/or hovering.

The patch is a temporary workaround to fix this for 64.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a51437b15d79
Disable parent process RDL r=mattwoodrow

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/a51437b15d79

Comment 8

[Miko Mynttinen]

Attachment: Bug 1496491 - Check for modified ancestors when updating WeakFrameRegion r=mattwoodrow

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d2772251e06
Check for modified ancestors when updating WeakFrameRegion r=mattwoodrow

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3d2772251e06

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello!
Reproduced the issue using Firefox 64.0a1 (20181004224156) on Windows 10x64.
The issue is verified using Firefox 69.0b7 (20190722201635) on Windows 10x64, macOS 10.14 and Ubuntu 18.04.