1491400 - Library window is missing dropmarker arrows

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: image.png

Dão, could this be related to bug 1487765 ?

Comment 1

[Dão Gottwald [:dao]]

Could be that, or bug 1470872.

Comment 2

[Dão Gottwald [:dao]]

Hmm, it's not clear to me how exactly this is failing. The dropmkarker's -moz-appearance, list-style-image, and display all seem to compute to the expected values, but somehow the image isn't rendered.

Comment 3

[Jason Duell]

Brindusa, is there someone who can help us find a regression range here?

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: expected behavior screenshot

Comment 5

[Daniel Bodea [:danibodea]]

I have performed a mozregression on this issue and these are my results:
16:21.67 INFO: No more inbound revisions, bisection finished.
16:21.67 INFO: Last good revision: 906330f7adc8cf71d9a39c1ff0fdd592ae7a9d28
16:21.67 INFO: First bad revision: 598ede9c5a5de8fcf23754e07a7c8079273013f4
16:21.67 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=906330f7adc8cf71d9a39c1ff0fdd592ae7a9d28&tochange=598ede9c5a5de8fcf23754e07a7c8079273013f4

Comment 6

[Dão Gottwald [:dao]]

(In reply to Bodea Daniel [:danibodea] from comment #5)
> I have performed a mozregression on this issue and these are my results:

Thanks.

Comment 7

[Mark Banner (:standard8)]

I just noticed this bug, and was curious, so I had a quick play. Adding "-moz-image-region: auto" onto all the xul:dropmarker elements shows the dropmarkers again.

It looks like there's image region setting for the main icons on the buttons themselves, but that is scoped to the whole button, rather than just the xul:image on the button:

https://searchfox.org/mozilla-central/source/browser/themes/osx/places/organizer.css#144-157

Comment 8

[Dão Gottwald [:dao]]

(In reply to Mark Banner (:standard8) from comment #7)
> I just noticed this bug, and was curious, so I had a quick play. Adding
> "-moz-image-region: auto" onto all the xul:dropmarker elements shows the
> dropmarkers again.
> 
> It looks like there's image region setting for the main icons on the buttons
> themselves, but that is scoped to the whole button, rather than just the
> xul:image on the button:
> 
> https://searchfox.org/mozilla-central/source/browser/themes/osx/places/
> organizer.css#144-157

This makes sense as -moz-image-region is inherited. So we should re-add -moz-image-region: auto to dropmarker.css.

Comment 9

[Dão Gottwald [:dao]]

Attachment: Bug 1491400 - Cut off inheritance for dropmarkers within other widgets where -moz-image-region might be set for the primary icon. r?standard8

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 9013553 [details]
Bug 1491400 - Cut off inheritance for dropmarkers within other widgets where -moz-image-region might be set for the primary icon. r?standard8

Mark Banner (:standard8) has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19165a491295
Cut off inheritance for dropmarkers within other widgets where -moz-image-region might be set for the primary icon. r=Standard8

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/19165a491295

Comment 13

[Daniel Bodea [:danibodea]]

This issue has been fixed in Nightly v64.0a1 from 2018-10-03.
The issue is now verified. Thank you.