1496557 - Expose Report Breakage for Cookie Restrictions on Release

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

With shipping disabled-by-default cookie restrictions in 63, we want to ensure users who enable it can report breakage. Thus we want to show the "Report Breakage" button on release, iff Cookie Restrictions was the only active blocker.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aebbddba77c6
Expose Report Breakage for Cookie Restrictions on Release. r=Gijs

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1496557 - Expose Report Breakage for Cookie Restrictions on Release. r=Gijs

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/aebbddba77c6

Comment 4

[Tony Cinotto [:tcinotto] (UTC-8)]

This has target milestone as 64. should it be 63?

Comment 5

[Johann Hofmann [:johannh]]

I think that's fine, I just need to do an uplift request. If I'm reading the emails that went around correctly this has been signed off Legal/Policy wise for 63.

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9014770 [details]
Bug 1496557 - Expose Report Breakage for Cookie Restrictions on Release. r=Gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: No harm on users, we simply would like to enable users to report breakage for users of the new (currently opt-in) cookie restrictions feature which is intended to become a default in the ~65 release.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: This needs some pref fiddling to check, I'll make sure that our team confirms that the patch worked on beta.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): We are adding a pref that controls a single button in the identity popup, the potential damage is very limited and the code is well covered with tests.

String changes made/needed: None

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9014770 [details]
Bug 1496557 - Expose Report Breakage for Cookie Restrictions on Release. r=Gijs

Minimal patch with tests and P1, uplift approved for 63 beta 13, thanks.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9c5344d443b6

Comment 9

[Andreea Pavel [:apavel]]

Backed out from beta for failing bc at browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed,busted,exception&classifiedState=unclassified&selectedJob=204033913&revision=5517b5cb5a92a6a6a2683757d659e0d43b3d4437

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204033913&repo=mozilla-beta&lineNumber=1310

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/1e0b0e805d0ad22e0135979511c9a1745b06c380

Comment 10

[Johann Hofmann [:johannh]]

Argh this is failing because we forgot to uplift bug 1493120 :(

I'll request uplift there...

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Uplift in bug 1493120 accepted, sheriffs please also uplift the patch in this bug, thanks!

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/87ddd19e4987

Comment 13

[Tanvi Vyas[:tanvi]]

After doing an update to Firefox 63 beta, I see that this pref is false by default:
browser.contentblocking.reportBreakage.enabled = false.

But I'm the experience is as desired - report breakage button shows up when only when cookie restrictions is the only protection.  So is there a second pref that I should be looking for in about:config?

Comment 14

[Johann Hofmann [:johannh]]

(In reply to Tanvi Vyas[:tanvi] from comment #13)
> After doing an update to Firefox 63 beta, I see that this pref is false by
> default:
> browser.contentblocking.reportBreakage.enabled = false.
> 
> But I'm the experience is as desired - report breakage button shows up when
> only when cookie restrictions is the only protection.  So is there a second
> pref that I should be looking for in about:config?

Yes, browser.contentblocking.rejecttrackers.reportBreakage.enabled