Closed
Bug 1496602
Opened 6 years ago
Closed 6 years ago
[mozmill] move timezone setting code from timezone-test to item-editing-helpers
Categories
(Calendar :: Internal Components, enhancement)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
6.7
People
(Reporter: Taraman, Assigned: Taraman)
Details
Attachments
(1 file)
|
7.81 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
There is code in the timezone test, that copes with the timezone Dialog. This should be moved to the item-editing helpers
|
Assignee | |
Updated•6 years ago
|
Summary: [mozmill] move timezone setting code from timezon-test to item-editing-helpers → [mozmill] move timezone setting code from timezone-test to item-editing-helpers
|
|
Assignee | |
Comment 1•6 years ago
|
||
This patch moves the timezone dialog code to test-item-editing-helperts.js and enables setData function to use it. try-run here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e51ee07dae5fcc4d4ccbf838be438912121bb3a2
Attachment #9026824 -
Flags: review?(geoff)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9026824 [details] [diff] [review] moveTimezoneCode.diff Review of attachment 9026824 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #9026824 -
Flags: review?(geoff) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
The try-run from yesterday showed a lot of failures, that should not be related to this patch, but to be sure I started another one that looks good: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=213346038&revision=6ec30009fd9752d544050f07827916529edce575
Pushed by Mozilla@Adrario.de: https://hg.mozilla.org/comm-central/rev/5af3c13ff2ee [mozmill] move timezone setting code from timezone-test to item-editing-helpers. r=darktrojan
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Target Milestone: --- → 6.7
You need to log in
before you can comment on or make changes to this bug.
Description
•