1496807 - Update strings (de Pocket-related and others) for 63

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Ed Lee :Mardak]

Attachment: de 63b12 (learn more, more recommendations)

[Tracking Requested - why for this release]: Strings were last updated in 63 over 5 weeks ago. In particular newly added pocket related strings are shown in English in 63b12 (see attachment)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4473

Comment 2

[Pascal Chevrel:pascalc]

Ed, did you ask for tracking for 63 release because you intend to uplift a patch in our last beta this week? Thanks

Comment 3

[Ed Lee :Mardak]

Yes, we'll want to uplift strings to 63.

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1496807 - Update strings (de Pocket-related and others) for 63

Comment 5

[Ed Lee :Mardak]

Attachment: screenshots with uplift patch attachment 9015308

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Ed Lee :Mardak (PTO Sep 15 - Oct 7) from comment #4)
> Created attachment 9015308 [details]
> Bug 1496807 - Update strings (de Pocket-related and others) for 63

Note for uplift: this doesn't have an actual l10n impact, .properties files uplifted are outside of localizable paths, and are exposed for localization only via mozilla-central.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9015308 [details]
Bug 1496807 - Update strings (de Pocket-related and others) for 63

Attachment 9015308 [details] for mozilla-beta is r+flod in phabricator

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1483655

User impact if declined: German users see english text (and other locales will have outdated / english strings). See attachment 9015309 [details] for comparison

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just updating strings

String changes made/needed: Yes, these are the translated strings and don't impact l10n as per comment 6

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9015308 [details]
Bug 1496807 - Update strings (de Pocket-related and others) for 63

Strings update with no l10n impact, uplift approved for 63 beta 14, thanks.

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad83fa2dacfe

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (63.0b14 Build ID - 20181011200118) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the Pocket strings are correctly displayed and translated according to the used locale build.