1496848 - Make it easier to deal with <xul:browser>'s flipping between different content processes

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, enhancement)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

In bug 1472212, a pref is being added that will allow us to use a separate content process for Activity Stream.

There are a few places in our testing code that expects to be able to attach web progress listeners to a tab hosting Activity Stream, and for those listeners to work properly as Activity Stream is navigated away from.

With the new Activity Stream content process, this breaks down, since the process flip causes the original message manager to be invalidated by a new one associated with the new process.

My first patch makes it so that nsIWebProgressListener's associated with a remote <xul:browser> will persist between remote-to-remote process flips (but _not_ from remote to non-remote process flips).

The second patch fixes up one of our Activity Stream content search tests so that instead of attempting to abort a test search from Activity Stream (presumably to save time), it allows the search to go through, and works properly with or without process flipping.

Comment 1

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79793bb3b7885146cd906462d0df299dcbd2fca7

Comment 2

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1496848 - Make RemoteWebProgressManager survive remote-to-remote process flips. r?felipe

For simplicity, we do not support remote-to-non-remote or non-remote-to-remote
nsIWebProgressListener persistence.

Comment 3

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1496848 - Get rid of message manager global from browser_ContentSearch.js. r?adw

This is to simplify a later patch that makes it easier to deal with process
flipping.

Depends on D7936

Comment 4

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1496848 - Make browser_ContentSearch.js work with process flips. r?adw

Depends on D7937

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5bbbe511ec5
Make RemoteWebProgressManager survive remote-to-remote process flips. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/2c3fc67d57b9
Get rid of message manager global from browser_ContentSearch.js. r=adw
https://hg.mozilla.org/integration/autoland/rev/9f11d400d1cc
Make browser_ContentSearch.js work with process flips. r=adw

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c5bbbe511ec5
https://hg.mozilla.org/mozilla-central/rev/2c3fc67d57b9
https://hg.mozilla.org/mozilla-central/rev/9f11d400d1cc