1496897 - AttributeError: 'Marionette' object has no attribute 'is_shutting_down' if Marionette kills application due to a timeout

Status: RESOLVED DUPLICATE of bug 1497094

(Testing :: Marionette Client and Harness, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=203797269&repo=autoland

https://queue.taskcluster.net/v1/task/IvXrCPOTTIevYZQX4nW4iw/runs/0/artifacts/public/logs/live_backing.log

22:19:08     INFO -  [Parent 702, StreamTrans #65] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 419
22:19:08     INFO -  [Parent 702, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 1127
22:21:24     INFO - TEST-UNEXPECTED-ERROR | testing/marionette/harness/marionette_harness/tests/unit/test_window_rect.py TestWindowRect.test_get_types | AttributeError: 'Marionette' object has no attribute 'is_shutting_down'
22:21:24     INFO - Traceback (most recent call last):
22:21:24     INFO -   File "/Users/cltbld/tasks/task_1538802264/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 140, in run
22:21:24     INFO -     self.setUp()
22:21:24     INFO -   File "/Users/cltbld/tasks/task_1538802264/build/tests/marionette/tests/testing/marionette/harness/marionette_harness/tests/unit/test_window_rect.py", line 33, in setUp
22:21:24     INFO -     self.marionette.set_window_rect(height=start_size["height"], width=start_size["width"])
22:21:24     INFO -   File "/Users/cltbld/tasks/task_1538802264/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1395, in set_window_rect
22:21:24     INFO -     body)
22:21:24     INFO -   File "/Users/cltbld/tasks/task_1538802264/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 33, in _
22:21:24     INFO -     if m.is_shutting_down:
22:21:24     INFO - TEST-INFO took 360400ms

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This seems to happen when a command times out. Andreas, could you please have a look at it? Maybe we just want to set this as property for the Marionette class. Thanks.

Comment 2

[Intermittent Failures Robot]

2 failures in 2708 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496897&startday=2018-10-01&endday=2018-10-07&tree=all

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reopening based on my feedback on bug 1497094.

Comment 5

[Intermittent Failures Robot]

4 failures in 2740 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 4

Platform breakdown:
* osx-10-10: 2
* windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1496897&startday=2018-10-08&endday=2018-10-14&tree=all

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

David says he will have a patch ready later today over on bug 1497094. So lets dupe it again.

Comment 7

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.