1497039 - "Forms & Autofill" section appears in "Home" preferences section when visiting about:preferences#home

Status: VERIFIED FIXED

(Firefox :: Preferences, defect, P1)

Description

[Tim Nguyen :ntim]

STR:
- Visit about:preferences#home
- Scroll down

Comment 1

[Franck (Wip)]

I can confirm this bug on Nightly 64.0a1 (BuildID 20181006220113, Windows NT 6.1; Win64).

The "Forms & Autofill" section also appears at the bottom of the page if opened with about:preferences#search or simply about:preferences from the hamburger menu.

In fact, it seems the "Forms & Autofill" section appears at the bottom of any opening tab except "Privacy & Security".

Moreover, if you switch preference tab then come back to the opening tab then the section had disappear.
  - to go about:preferences#home
  - scroll down to find the "Forms & Autofill" section
  - switch to "Privacy & Security"
  - scroll to find the "Forms & Autofill" section at its rightful place
  - switch back to "General"
  - scroll down: the "Forms & Autofill" section is no longer there (has it should)

Comment 2

[Alice0775 White]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bd02cc115cb69ec8193ea60be49006b63b9ba8c8&tochange=3de6e1582de91e37bfaa1893aac4d026d1cebb7a

Comment 3

[:Gijs (he/him)]

Jared, ni for the regression. :-)

Comment 4

[Matthew N. [:MattN]]

Adding to our current milestone.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

So the cause of this was always happening but wasn't visible before. The Forms & Autofill section is being appended to the DOM after the initial run of the 'search()' function which shows/hides children of the mainPrefPane for the selected category. Changing categories after the page loads does properly hide the Forms & Autofill section. This bug wasn't visible before because the Forms & Autofill section was being appended to a child of the mainPrefPane, and that child was hidden by search().

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

This patch is waiting on the patch in bug 1429940 to land, and will be rebased on top of that.

Comment 8

[:Paolo Amadini]

Thanks Jared for thinking about this, but in fact we may end up landing the Preferences groupbox patch in the next release, so feel free to land this now and I'll rebase my patches afterwards.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb2a83cba95a
Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN

Comment 11

[Dorel Luca [:dluca]]

Backed out changeset eb2a83cba95a (bug 1497039) for XPCshell failures in browser/extensions/formautofill/test/unit/test_reconcile.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=206233420&repo=autoland&lineNumber=2306

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=eb2a83cba95aafab7713af2a444de144320b31e9

Backout:
https://hg.mozilla.org/integration/autoland/rev/2b7afed367792d6158d2f1ac18e614091cd9b6af

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Gonna attempt to reland it since the failures don't appear to be related to this bug.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afdfeb4c004c
Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/afdfeb4c004c

Comment 15

[Hani Yacoub]

Build ID: 20181019005426
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.