Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r?MattN
46 bytes, text/x-phabricator-request
|Details | Review|
STR: - Visit about:preferences#home - Scroll down
I can confirm this bug on Nightly 64.0a1 (BuildID 20181006220113, Windows NT 6.1; Win64). The "Forms & Autofill" section also appears at the bottom of the page if opened with about:preferences#search or simply about:preferences from the hamburger menu. In fact, it seems the "Forms & Autofill" section appears at the bottom of any opening tab except "Privacy & Security". Moreover, if you switch preference tab then come back to the opening tab then the section had disappear. - to go about:preferences#home - scroll down to find the "Forms & Autofill" section - switch to "Privacy & Security" - scroll to find the "Forms & Autofill" section at its rightful place - switch back to "General" - scroll down: the "Forms & Autofill" section is no longer there (has it should)
Jared, ni for the regression. :-)
Priority: -- → P1
Adding to our current milestone.
Assignee: nobody → jaws
7 months ago
So the cause of this was always happening but wasn't visible before. The Forms & Autofill section is being appended to the DOM after the initial run of the 'search()' function which shows/hides children of the mainPrefPane for the selected category. Changing categories after the page loads does properly hide the Forms & Autofill section. This bug wasn't visible before because the Forms & Autofill section was being appended to a child of the mainPrefPane, and that child was hidden by search().
This patch is waiting on the patch in bug 1429940 to land, and will be rebased on top of that.
Depends on: 1429940
Thanks Jared for thinking about this, but in fact we may end up landing the Preferences groupbox patch in the next release, so feel free to land this now and I'll rebase my patches afterwards.
No longer depends on: 1429940
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/eb2a83cba95a Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Backed out changeset eb2a83cba95a (bug 1497039) for XPCshell failures in browser/extensions/formautofill/test/unit/test_reconcile.js. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=206233420&repo=autoland&lineNumber=2306 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=eb2a83cba95aafab7713af2a444de144320b31e9 Backout: https://hg.mozilla.org/integration/autoland/rev/2b7afed367792d6158d2f1ac18e614091cd9b6af
Gonna attempt to reland it since the failures don't appear to be related to this bug.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/afdfeb4c004c Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Build ID: 20181019005426 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.