Closed Bug 1470184 Opened 2 years ago Closed 2 years ago

Update the Preferences text and layout for Web Payments

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- verified

People

(Reporter: epang, Assigned: jaws)

References

Details

(Whiteboard: [webpayments] [user-testing])

Attachments

(2 files)

Update content in preferences
Assignee: nobody → jsavory
Status: NEW → ASSIGNED
Priority: P3 → P1
Flags: qe-verify-
Attached image Firefox Preferences
Update to Firefox Preferences from ixd spec.
Flow can be found here:
https://mozilla.invisionapp.com/d/main#/console/13170472/288300821/preview
Assignee: jsavory → nobody
Status: ASSIGNED → NEW
Flags: qe-verify-
Priority: P1 → P3
Whiteboard: [webpayments] [ux] → [webpayments-reserve]
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [webpayments-reserve] → [webpayments-reserve][ux]
Whiteboard: [webpayments-reserve][ux] → [webpayments-reserve]
Priority: P3 → P2
Whiteboard: [webpayments-reserve] → [webpayments-reserve] [user-testing]
Summary: Fix the Preferences text and layout → Update the Preferences text and layout for Web Payments
Whiteboard: [webpayments-reserve] [user-testing] → [webpayments] [user-testing]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
The description text should get reviewed by Brian
Hi Brian, the attached patch introduces the following description to the Preferences for the "Forms & Autofill" section:
"Firefox saves your address and credit cards to help you checkout faster. You can edit, delete, and create new credit cards and addresses here."

This is mostly the same from the attached mockup, except that I removed the <product name> part. However, the Address autofill part is not always used for "checkout" so the string in my opinion isn't really what we want.
Flags: needinfo?(brjones)
Comment on attachment 9012255 [details]
Bug 1470184 - Update the Preferences text and layout for Web Payments. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.
Attachment #9012255 - Flags: review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Hi Brian, the attached patch introduces the following description to the
> Preferences for the "Forms & Autofill" section:
> "Firefox saves your address and credit cards to help you checkout faster.
> You can edit, delete, and create new credit cards and addresses here."
> 
> This is mostly the same from the attached mockup, except that I removed the
> <product name> part. However, the Address autofill part is not always used
> for "checkout" so the string in my opinion isn't really what we want.

Jared, if I'm following, I think you're suggesting something like:
Firefox can save your address and credit card information. You can add, delete, and edit address and credit card information here.

Works for me!
Flags: needinfo?(brjones)
Comment on attachment 9012255 [details]
Bug 1470184 - Update the Preferences text and layout for Web Payments. r?MattN

Francesco Lodolo [:flod] has approved the revision.
Attachment #9012255 - Flags: review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/3de6e1582de9
Update the Preferences text and layout for Web Payments. r=flod,MattN
https://hg.mozilla.org/mozilla-central/rev/3de6e1582de9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Hi Eric,

Unfortunately, I cannot access this document to check out the new Preferences text and layout: https://mozilla.invisionapp.com/d/main#/console/13170472/288300821/preview

Can you please provide it differently so I can verify the fix?

Thanks
Flags: needinfo?(epang)
Yeah, that's a URL which requires auth. https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872 is the public URL.
Flags: needinfo?(epang)
Verified the  Preferences text and layout based on design doc:https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872.

There are two differences that I would like to point out:

1. "Nightly can save your address and credit card information." description is displayed instead of the one mentioned in Comment 5 
2. The "Save Credit Cards..." button is quite wider than the one that can be seen in the spec doc. Is this intended or not?

Here is a screenshot of how it looks now on all OS:
https://imgur.com/WQKdv1w
Flags: needinfo?(jaws)
(In reply to Timea Babos from comment #11)
> Verified the  Preferences text and layout based on design
> doc:https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872.
> 
> There are two differences that I would like to point out:
> 
> 1. "Nightly can save your address and credit card information." description
> is displayed instead of the one mentioned in Comment 5 

Yes, this string was further tweaked to remove the product name portion. The second sentence, "You can edit, delete, and create new credit cards and addresses here." was also removed since those types of operations are common elsewhere within preferences but don't have a similar description string. It felt out of place and redundant.

> 2. The "Save Credit Cards..." button is quite wider than the one that can be
> seen in the spec doc. Is this intended or not?
> Here is a screenshot of how it looks now on all OS:
> https://imgur.com/WQKdv1w

Your screenshot is the intended outcome. Some alignments that are made on the spec don't match the paddings that we place on buttons. Thanks for the questions :)
Flags: needinfo?(jaws)
Based on comment 12 I'll mark this bug as verified.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1497039
Blocks: 1497523
You need to log in before you can comment on or make changes to this bug.