1470184 - Update the Preferences text and layout for Web Payments

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Eric Pang [:epang] UX]

Update content in preferences

Comment 1

[Eric Pang [:epang] UX]

Attachment: Firefox Preferences

Update to Firefox Preferences from ixd spec.
Flow can be found here:
https://mozilla.invisionapp.com/d/main#/console/13170472/288300821/preview

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1470184 - Update the Preferences text and layout for Web Payments. r?MattN

The description text should get reviewed by Brian

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Hi Brian, the attached patch introduces the following description to the Preferences for the "Forms & Autofill" section:
"Firefox saves your address and credit cards to help you checkout faster. You can edit, delete, and create new credit cards and addresses here."

This is mostly the same from the attached mockup, except that I removed the <product name> part. However, the Address autofill part is not always used for "checkout" so the string in my opinion isn't really what we want.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 9012255 [details]
Bug 1470184 - Update the Preferences text and layout for Web Payments. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 5

[Brian Jones]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Hi Brian, the attached patch introduces the following description to the
> Preferences for the "Forms & Autofill" section:
> "Firefox saves your address and credit cards to help you checkout faster.
> You can edit, delete, and create new credit cards and addresses here."
> 
> This is mostly the same from the attached mockup, except that I removed the
> <product name> part. However, the Address autofill part is not always used
> for "checkout" so the string in my opinion isn't really what we want.

Jared, if I'm following, I think you're suggesting something like:
Firefox can save your address and credit card information. You can add, delete, and edit address and credit card information here.

Works for me!

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 9012255 [details]
Bug 1470184 - Update the Preferences text and layout for Web Payments. r?MattN

Francesco Lodolo [:flod] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de6e1582de9
Update the Preferences text and layout for Web Payments. r=flod,MattN

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/3de6e1582de9

Comment 9

[Timea Cernea [:tbabos][inactive]]

Hi Eric,

Unfortunately, I cannot access this document to check out the new Preferences text and layout: https://mozilla.invisionapp.com/d/main#/console/13170472/288300821/preview

Can you please provide it differently so I can verify the fix?

Thanks

Comment 10

[Matthew N. [:MattN]]

Yeah, that's a URL which requires auth. https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872 is the public URL.

Comment 11

[Timea Cernea [:tbabos][inactive]]

Verified the  Preferences text and layout based on design doc:https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872.

There are two differences that I would like to point out:

1. "Nightly can save your address and credit card information." description is displayed instead of the one mentioned in Comment 5 
2. The "Save Credit Cards..." button is quite wider than the one that can be seen in the spec doc. Is this intended or not?

Here is a screenshot of how it looks now on all OS:
https://imgur.com/WQKdv1w

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Timea Babos from comment #11)
> Verified the  Preferences text and layout based on design
> doc:https://mozilla.invisionapp.com/share/ABFIO5F9NPZ#/screens/275361872.
> 
> There are two differences that I would like to point out:
> 
> 1. "Nightly can save your address and credit card information." description
> is displayed instead of the one mentioned in Comment 5 

Yes, this string was further tweaked to remove the product name portion. The second sentence, "You can edit, delete, and create new credit cards and addresses here." was also removed since those types of operations are common elsewhere within preferences but don't have a similar description string. It felt out of place and redundant.

> 2. The "Save Credit Cards..." button is quite wider than the one that can be
> seen in the spec doc. Is this intended or not?
> Here is a screenshot of how it looks now on all OS:
> https://imgur.com/WQKdv1w

Your screenshot is the intended outcome. Some alignments that are made on the spec don't match the paddings that we place on buttons. Thanks for the questions :)

Comment 13

[Hani Yacoub, Desktop QA]

Based on comment 12 I'll mark this bug as verified.