Closed Bug 1497062 Opened 6 years ago Closed 6 years ago

Perma Windows opt browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15

Categories

(Firefox :: Migration, defect, P1)

Product:
Firefox
Component:
Migration
Platform:
All
Windows
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 + fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure) 

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=203927746&repo=try

https://queue.taskcluster.net/v1/task/J27dMmxfSOGOjxXyOJQx0A/runs/0/artifacts/public/logs/live_backing.log

15:52:15     INFO -  1538927535203	Marionette	TRACE	3 -> [0,13,"Marionette:SetContext",{"value":"content"}]
15:52:15     INFO -  1538927535203	Marionette	TRACE	3 <- [1,13,null,{"value":null}]
15:52:15     INFO -  1538927535204	Marionette	TRACE	3 -> [0,14,"WebDriver:GetPageSource",{}]
15:52:15     INFO -  1538927535206	Marionette	TRACE	3 <- [1,14,null,{"value":"<html><head></head><body></body></html>"}]
15:52:15     INFO -  1538927535206	Marionette	TRACE	3 -> [0,15,"Marionette:SetContext",{"value":"chrome"}]
15:52:15    ERROR -  TEST-UNEXPECTED-FAIL | browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove
15:52:15     INFO -  Traceback (most recent call last):
15:52:15     INFO -    File "Z:\task_1538926272\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 159, in run
15:52:15     INFO -      testMethod()
15:52:15     INFO -    File "Z:\task_1538926272\build\tests\marionette\tests\browser\components\migration\tests\marionette\test_refresh_firefox.py", line 586, in testReset
15:52:15     INFO -      self.doReset()
15:52:15     INFO -    File "Z:\task_1538926272\build\tests\marionette\tests\browser\components\migration\tests\marionette\test_refresh_firefox.py", line 581, in doReset
15:52:15     INFO -      "Reset profile path should contain profile name to remove")
15:52:15     INFO -  TEST-INFO took 10316ms
Summary: Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove → Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15
[Tracking Requested - why for this release]:
status-firefox64: --- → affected
tracking-firefox64: --- → ?
Summary: Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15 → Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove
Summary: Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove → Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15
status-firefox62: --- → unaffected
status-firefox63: --- → unaffected
status-firefox-esr60: --- → unaffected
Summary: Intermittent browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15 → Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15
Aryx: i looked over the Mn and en_US failures a bit and it appears in the last 3 days of simulations the failures changed a bit. 
This failure here appeared on the beta sim from Saturday, the 6th of October and the only recent change to this file i found was https://hg.mozilla.org/mozilla-central/rev/8dfe8c9a70d8

Can you please take a look if you find more info here?  These are all beta-sim perma failures. 

TEST-UNEXPECTED-ERROR | testing\firefox-ui\tests\functional\sessionstore\test_restore_windows_after_restart_and_quit.py TestSessionStoreDisabled.test_restore_with_restart | IOError: Process has been unexpectedly closed (Exit code: 0) (Reason: Requested restart of the application was aborted)  Bug 1496759

TEST-UNEXPECTED-FAIL | testing\firefox-ui\tests\functional\sessionstore\test_restore_windows_after_restart_and_quit.py TestSessionStoreDisabled.test_restore_with_restart | AssertionError: Non private browsing windows should have  Bug 1497116

TEST-UNEXPECTED-FAIL | browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove Bug 1497062
Flags: needinfo?(aryx.bugmail)
On Saturday, we added a backout to the beta simulations:
"Backed out changeset 37fcdbb6756c (bug 1495983)". That was in anticipation to fix the mn and en-us failures on Windows and (Bug 1496759) but didn't work but might have still affected the failure messages.
Flags: needinfo?(aryx.bugmail)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
This is not a dupe of bug 1496759, which is actually not present anymore and has been fixed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Also the beta simulation job as run here has been done on Oct 7th and not Oct 15th.
Summary: Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15 → Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-07
It's about the beta merges which started yesterday, not when the beta simulation has been done.
Summary: Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-07 → Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15
So the assertion as written as far from ideal:

>        self.assertTrue(self.profileNameToRemove in self.reset_profile_path,
>                        "Reset profile path should contain profile name to remove")

Instead it should use `self.assertIn()`, which would then also show us the real path as in `self.reset_profile_path`. With this additional information it might be more clear what's going on. I will file a new bug to get this improvement landed on central. Then we can check back with the next beta simulation.
Depends on: 1499367
Were there earlier beta simulations and did those not have this problem? I'm wondering if I somehow broke this with the changes from bug 1488926 or something.
Flags: needinfo?(aryx.bugmail)
Gijs, does that patch contain Windows specific code paths given that this failure only happens for Windows opt builds?
OS: Unspecified → Windows
Hardware: Unspecified → All
Summary: Perma browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15 → Perma Windows opt browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testReset | AssertionError: Reset profile path should contain profile name to remove when Gecko 64 merges to Beta on 2018-10-15
Wait your patch landed 5 days ago on central. The failure is already present before. So no, it has not been caused by this bug.
Maybe this has the same underlying reason as bug 1400780 comment 52. Tomorrow I will know more.
Depends on: 1493796
I have just pushed a try build for bug 1493796, which is actually the underlying problem here. It will temporarily backout the change as made in https://hg.mozilla.org/integration/autoland/rev/8793e332890e, and skip the appropriate mozprocess unit test on Windows only.
Priority: P5 → P1
The patch on bug 1493796 backed out the failing code, so with the next uplift to beta this will be fixed.
Assignee: nobody → hskupin
status-firefox64: affected → fixed
Target Milestone: --- → Firefox 64
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.