Closed Bug 1499367 Opened 10 months ago Closed 10 months ago

Improve assertion for profileNameToRemove in test_refresh_firefox.py

Categories

(Firefox :: Migration, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- unaffected
firefox64 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

(In reply to Henrik Skupin (:whimboo) from bug 1497062 comment #9)
> So the assertion as written is far from ideal:
> 
> >        self.assertTrue(self.profileNameToRemove in self.reset_profile_path,
> >                        "Reset profile path should contain profile name to remove")
> 
> Instead it should use `self.assertIn()`, which would then also show us the
> real path as in `self.reset_profile_path`. With this additional information
> it might be more clear what's going on. I will file a new bug to get this
> improvement landed on central. Then we can check back with the next beta
> simulation.
assertIn(el, list) should be favored over assertTrue(el in list),
which gives clear details about what is different.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/247936437060
Improve assertion for profileNameToRemove in test_refresh_firefox.py. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/247936437060
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.