1499367 - Improve assertion for profileNameToRemove in test_refresh_firefox.py

Status: RESOLVED FIXED

(Firefox :: Migration, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Henrik Skupin (:whimboo) from bug 1497062 comment #9)
> So the assertion as written is far from ideal:
> 
> >        self.assertTrue(self.profileNameToRemove in self.reset_profile_path,
> >                        "Reset profile path should contain profile name to remove")
> 
> Instead it should use `self.assertIn()`, which would then also show us the
> real path as in `self.reset_profile_path`. With this additional information
> it might be more clear what's going on. I will file a new bug to get this
> improvement landed on central. Then we can check back with the next beta
> simulation.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=258772d0c86e11d517ae3343226ffb43d1bd4ece

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1499367 - Improve assertion for profileNameToRemove in test_refresh_firefox.py. r?gijs

assertIn(el, list) should be favored over assertTrue(el in list),
which gives clear details about what is different.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/247936437060
Improve assertion for profileNameToRemove in test_refresh_firefox.py. r=Gijs

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/247936437060