Closed Bug 1499367 Opened 2 years ago Closed 2 years ago
Improve assertion for profile
Name To Remove in test _refresh _firefox .py
46 bytes, text/x-phabricator-request
|Details | Review|
(In reply to Henrik Skupin (:whimboo) from bug 1497062 comment #9) > So the assertion as written is far from ideal: > > > self.assertTrue(self.profileNameToRemove in self.reset_profile_path, > > "Reset profile path should contain profile name to remove") > > Instead it should use `self.assertIn()`, which would then also show us the > real path as in `self.reset_profile_path`. With this additional information > it might be more clear what's going on. I will file a new bug to get this > improvement landed on central. Then we can check back with the next beta > simulation.
assertIn(el, list) should be favored over assertTrue(el in list), which gives clear details about what is different.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/247936437060 Improve assertion for profileNameToRemove in test_refresh_firefox.py. r=Gijs
You need to log in before you can comment on or make changes to this bug.