1497279 - Check browser.xul.error_pages.expert_bad_cert in front-end code instead of nsDocShell.cpp

Status: NEW

(Firefox :: Security, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

This is a low-hanging fruit in our conquest to move all front-end logic for cert error pages out of nsDocShell.cpp.

Currently, nsDocShell checks the browser.xul.error_pages.expert_bad_cert pref and assigns a value to the cssClass query string parameter if it's true: https://searchfox.org/mozilla-central/rev/29aea2a2a3bd0f5e25ce0b60a76053fb25ba5149/docshell/base/nsDocShell.cpp#4520

Instead of doing this, we can simply use JS in NetErrorChild.jsm to open the advanced panel by default if the pref is set.

Comment 1

[ekikoh]

Hi Johann, I'am an outreacy applicant, and would like to give this bug a try, with some mentorship of course. I have a development environment fully set-up and have successfully built firefox-destop.
Please, reply when you find the time so I know how to progress.

Thanks.

Comment 2

[Asra Q [:aqadri]]

Hi Johann, Can I work on this?

Comment 3

[Johann Hofmann [:johannh]]

Hey folks, sorry for taking so long to respond here, but I don't really feel comfortable mentoring this right now as I don't have a clear idea about what to do with mobile/core. If anyone wants to really give this a go I would accept a patch but I won't assign anyone for exploration.

Thanks!